Bugzilla Bug 188918

After calculating dependencies, revdep-rebuild prints:

 * All prepared. Starting rebuild
emerge --oneshot  =emerge: =there =are =no =ebuilds =to =satisfy ="=".
..........
Calculating dependencies /
emerge: there are no ebuilds to satisfy "=emerge:".

 *
 * revdep-rebuild failed to emerge all packages.
 * you have the following choices:
 * - If emerge failed during the build, fix the problems and re-run
revdep-rebuild.
 * - Use /etc/portage/package.keywords to unmask a newer version of the
package.
 *   (and remove /root/.revdep-rebuild.5_order to be evaluated again)
 * - Modify the above emerge command and run it manually.
 * - Compile or unmerge unsatisfied packages manually,
 *   remove temporary files, and try again.
 *   (you can edit package/ebuild list first)
 *
 * To remove temporary files, please run:
 * rm /root/.revdep-rebuild*.?_*


Reproducible: Always

Steps to Reproduce:
1.Run revdep-rebuild
2.
3.

Actual Results:  
It appeared to create an invalid emerge command.

Expected Results:  
It should have generated a correct emerge command to resolve the broken
packages.

# emerge --info
Portage 2.1.2.11 (default-linux/x86/2006.1/desktop, gcc-4.1.2, glibc-2.5-r4,
2.6.18-gentoo-r2 i686)
=================================================================
System uname: 2.6.18-gentoo-r2 i686 AMD Athlon(tm) MP Processor 1800+
Gentoo Base System release 1.12.9
Timestamp of tree: Sun, 12 Aug 2007 16:30:01 +0000
dev-java/java-config: 1.3.7, 2.0.33-r1
dev-lang/python:     2.3.5-r3, 2.4.4-r4
dev-python/pycrypto: 2.0.1-r6
sys-apps/sandbox:    1.2.17
sys-devel/autoconf:  2.13, 2.61
sys-devel/automake:  1.4_p6, 1.5, 1.6.3, 1.7.9-r1, 1.8.5-r3, 1.9.6-r2, 1.10
sys-devel/binutils:  2.17
sys-devel/gcc-config: 1.3.16
sys-devel/libtool:   1.5.23b
virtual/os-headers:  2.6.21
ACCEPT_KEYWORDS="x86"
AUTOCLEAN="yes"
CBUILD="i686-pc-linux-gnu"
CFLAGS="-O2 -march=athlon-xp -pipe"
CHOST="i686-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/kde/3.5/env /usr/kde/3.5/share/config
/usr/kde/3.5/shutdown /usr/share/X11/xkb /usr/share/config"
CONFIG_PROTECT_MASK="/etc/env.d /etc/env.d/java/ /etc/gconf
/etc/php/apache2-php5/ext-active/ /etc/php/cgi-php5/ext-active/
/etc/php/cli-php5/ext-active/ /etc/revdep-rebuild /etc/terminfo
/etc/texmf/web2c"
CXXFLAGS="-O2 -march=athlon-xp -pipe"
DISTDIR="/usr/portage/distfiles"
FEATURES="distlocks metadata-transfer parallel-fetch sandbox sfperms strict"
GENTOO_MIRRORS="http://distfiles.gentoo.org
http://distro.ibiblio.org/pub/linux/distributions/gentoo"
MAKEOPTS="-j2"
PKGDIR="/usr/portage/packages"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress
--force --whole-file --delete --delete-after --stats --timeout=180
--exclude=/distfiles --exclude=/local --exclude=/packages
--filter=H_**/files/digest-*"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/portage/local/layman/haskell
/usr/portage/local/layman/nx"
SYNC="rsync://192.168.0.1/gentoo-portage"
USE="3dnow 3dnowext X a52 aac aalib alsa apache2 arts avi berkdb bitmap-fonts
cairo cdda cdr cli console cracklib crypt ctype cups dbus dri dts dvd dvdr eds
emboss encode esd fam ffmpeg firefox flac fortran gcj gdbm gif gnome gpm
gstreamer gtk hal howl iconv imap ipv6 isdnlog jabber java jpeg kde ldap mad
maildir matroska midi mikmod mmx mmxext mp3 mpeg msn mudflap mysql ncurses nls
nptl nptlonly nsplugin nvidia ogg opengl openmp oss pam pcre perl png ppds pppd
python qt3 qt4 quicktime readline reflection sdl session spell spl sse ssl svg
svga tcpd theora truetype truetype-fonts type1-fonts unicode vorbis win32codecs
wxwindows x264 x86 xml xorg xv zlib" ALSA_CARDS="ali5451 als4000 atiixp
atiixp-modem bt87x ca0106 cmipci emu10k1 emu10k1x ens1370 ens1371 es1938 es1968
fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx
via82xx-modem ymfpci" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop
empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mulaw multi
null plug rate route share shm softvol" ELIBC="glibc" INPUT_DEVICES="keyboard
mouse evdev" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780
lb216 lcdm001 mtxorb ncurses text" USERLAND="GNU" VIDEO_CARDS="apm ark chips
cirrus cyrix dummy fbdev glint i128 i740 i810 imstt mach64 mga neomagic nsc nv
r128 radeon rendition s3 s3virge savage siliconmotion sis sisusb tdfx tga
trident tseng v4l vesa vga via vmware voodoo"
Unset:  CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LANG, LC_ALL, LDFLAGS,
LINGUAS, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS

Created an attachment (id=128110) [details]
The contents of revdep-rebuild.0_env

Created an attachment (id=128113) [details]
Another output file

Created an attachment (id=128114) [details]
Another output file

Created an attachment (id=128115) [details]
revdep-rebuild.3_ldd_errors

Created an attachment (id=128116) [details]
revdep-rebuild.3_rebuild

Created an attachment (id=128117) [details]
revdep-rebuild.4_ebuilds

Created an attachment (id=128119) [details]
revdep-rebuild.4_package_owners

Created an attachment (id=128120) [details]
revdep-rebuild.4_packages

Created an attachment (id=128122) [details]
revdep-rebuild.4_packages_raw

Created an attachment (id=128124) [details]
revdep-rebuild.5_order

Created an attachment (id=128125) [details]
revdep-rebuild.6_status

Created an attachment (id=128201) [details]
revdep-rebuild-rewrite.patch

Here, this should fix it. I didn't anticipate that revdep-rebuild.4_ebuilds
could have blank lines in it. Using arrays, blank lines don't matter so much.

Please don't close bugs, until the fix is released.

Blank lines in revdep-rebuild.4_ebuilds are caused by an ebuild no longer being
available for the corresponding package in revdep-rebuild.4_packages.  In this
case it was for gnome-extra/gtkhtml-1.1.10-r1.

$ svn commit -m "Correctly handle the case where an ebuild no longer exists for
a package (Bug #188918)"
Sending        ChangeLog
Sending        src/revdep-rebuild/revdep-rebuild-rewrite
Transmitting file data ..
Committed revision 435.

Released in gentoolkit-0.2.4_pre7