Bug List: (This bug is not in your last search results)   Show last search results      Search page      Enter new bug
Bug#: 188780
Alias:
Product:
Component:
Status: RESOLVED
Resolution: FIXED
Assigned To: Portage team <dev-portage@gentoo.org>
Hardware:
OS:
Version:
Priority:
Severity:
Reporter: Brant Gurganus <bugs.gentoo.org@gurganus.name>
Add CC:
CC:
Remove selected CCs
URL:
Summary:
Status Whiteboard:
Keywords:

Filename Description Type Creator Created Size Actions
Create a New Attachment (proposed patch, testcase, etc.) View All

Bug 188780 depends on: Show dependency tree
Bug 188780 blocks: 210077 216231
Votes: 0    Show votes for this bug    Vote for this bug

Additional Comments: (this is where you put emerge --info)


Not eligible to see or edit group visibility for this bug.






View Bug Activity   |   Format For Printing   |   XML   |   Clone This Bug


Description:   Opened: 2007-08-14 02:50 0000
As evidenced by its output, etc-update does not check for valid input before
trying to process it.

Reproducible: Always

Steps to Reproduce:
1. Run etc-update.
2. At a prompt, use "1y" as input.

Actual Results:  
/usr/sbin/etc-update: line 215: read: 1y: value too great for base (error token
is "1y")

Expected Results:  
The software should recover from this error and say that "1y" was not an
option.

------- Comment #1 From Zac Medico 2007-08-15 07:08:09 0000 -------
It's better than it used to be (bug 143881). I suppose we can stop trying to
read it into an integer type in order to avoid that error all together.

------- Comment #2 From Brant Gurganus 2007-08-15 09:41:43 0000 -------
I'd have to be more familiar with the language etc-update is written in, but
the data type isn't the problem. It does need to be an integer, unless
non-integer input is expected at some point. In my brief testing, it seemed
like the select syntax of bash was more robust. Am I correct there? Would
select be better?

------- Comment #3 From Dawid Węgliński 2008-11-23 16:50:57 0000 -------
Isn't it fixed already? :)

------- Comment #4 From Zac Medico 2008-11-23 19:52:07 0000 -------
In svn r12053 I've fixed it to show a more human readable error message, like
this:

Value '1y' is not valid. Please enter an integer value:

(In reply to comment #3)
> Isn't it fixed already? :)

Well, it was fixed in the sense that the program would continue to run.
However, the error message was not very good.

------- Comment #5 From Zac Medico 2008-11-27 19:20:54 0000 -------
This is fixed in 2.1.6_rc1 and 2.2_rc16.

Bug List: (This bug is not in your last search results)   Show last search results      Search page      Enter new bug