Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 188343 - app-portage/gentoolkit-0.2.4_pre6 - revdep-rebuild no longer re-using the results from --pretend run
Summary: app-portage/gentoolkit-0.2.4_pre6 - revdep-rebuild no longer re-using the res...
Status: RESOLVED FIXED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Tools (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Portage Tools Team
URL:
Whiteboard:
Keywords: InVCS
: 101930 189742 (view as bug list)
Depends on:
Blocks: 170220
  Show dependency tree
 
Reported: 2007-08-10 13:49 UTC by Jakub Moc (RETIRED)
Modified: 2008-02-25 19:04 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
evdep-rebuild_r453_combined_opts.patch (revdep-rebuild_r453_combined_opts.patch,11.79 KB, patch)
2008-01-22 21:58 UTC, michael@smith-li.com
Details | Diff
revdep-rebuild.1_r442_combined_opts.patch (revdep-rebuild.1_r442_combined_opts.patch,1.69 KB, patch)
2008-01-22 22:00 UTC, michael@smith-li.com
Details | Diff
revdep-rebuild_r453_combined_opts.patch (revdep-rebuild_r453_combined_opts.patch,11.81 KB, patch)
2008-01-28 23:52 UTC, michael@smith-li.com
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jakub Moc (RETIRED) gentoo-dev 2007-08-10 13:49:49 UTC
Is this change intentional? I find it rather annoying, used to run w/ -pv first to see how much stuff needs to be rebuilt, no longer possible, it always rescans everything, which takes ages.
Comment 1 Paul Varner (RETIRED) gentoo-dev 2007-08-10 17:30:20 UTC
No the change was not intentional. I will look at fixing it to act the old way. 
I am assuming that you are running 'revdep-rebuild -pv', if not let me know what you are runnning.
Comment 2 Jakub Moc (RETIRED) gentoo-dev 2007-08-10 17:32:57 UTC
(In reply to comment #1)
> I am assuming that you are running 'revdep-rebuild -pv'

Yup. :) 

Comment 3 michael@smith-li.com 2007-08-23 20:44:20 UTC
revdep-rebuild has never actually tried to parse single-letter options like that. -pv would just get passed directly to EMERGE_OPTIONS. -p -v should work in all versions of revdep-rebuild.

In the new version, -pv would be passed to EMERGE_OPTIONS, but r-r would not recognize it as the same as --pretend, and things would break.

I intended to write some logic for r-r to handle single letter options, but the old versions of r-r used options like -nc == --no-color, so any attempt I do will break compatibility with old versions.

Paul, maybe we should deprecate options like -nc and spit out ewarns when users use them, to prepare for a future version that will accept combined single-letter options?
Comment 4 michael@smith-li.com 2008-01-22 21:58:07 UTC
Created attachment 141603 [details, diff]
evdep-rebuild_r453_combined_opts.patch

This patch against r453 should allow the use of combined flags like -pv. Please test :)
Comment 5 michael@smith-li.com 2008-01-22 22:00:40 UTC
Created attachment 141607 [details, diff]
revdep-rebuild.1_r442_combined_opts.patch

Patch against rev 442 of the man page to reflect the changes in comment #4.
Comment 6 michael@smith-li.com 2008-01-28 16:05:55 UTC
This is actually a dupe of bug #101930. I just never noticed it before...
Comment 7 michael@smith-li.com 2008-01-28 23:52:03 UTC
Created attachment 142063 [details, diff]
revdep-rebuild_r453_combined_opts.patch

Bugfix -- the previous patch didn't take into account emerge options after the '--' flag.
Comment 8 Paul Varner (RETIRED) gentoo-dev 2008-02-18 17:13:36 UTC
*** Bug 189742 has been marked as a duplicate of this bug. ***
Comment 9 michael@smith-li.com 2008-02-21 16:53:10 UTC
Rev 466
Comment 10 Paul Varner (RETIRED) gentoo-dev 2008-02-25 19:04:29 UTC
*** Bug 101930 has been marked as a duplicate of this bug. ***