Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 186652 - [PATCH genkernel 2/4] Add customized modules_load support
Summary: [PATCH genkernel 2/4] Add customized modules_load support
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Hosted Projects
Classification: Unclassified
Component: genkernel (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo Genkernel Maintainers
URL:
Whiteboard:
Keywords: Inclusion
: 154047 (view as bug list)
Depends on: 186650
Blocks: 245389 186653
  Show dependency tree
 
Reported: 2007-07-26 07:48 UTC by Robin Johnson
Modified: 2017-01-03 05:06 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
0002-Add-customized-modules_load-support.patch (0002-Add-customized-modules_load-support.patch,3.01 KB, patch)
2007-07-26 07:49 UTC, Robin Johnson
Details | Diff
Add support MODULES_* override from /etc/genkernel.conf for genkernel 3.4.45 version (genkernel.patch,676 bytes, patch)
2013-05-07 09:16 UTC, mihalych
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2007-07-26 07:48:57 UTC
This allows users to specify exactly which modules to include in the initramfs
for their system. They must remember to include dependancy modules themselves!
(Eg sata_* depend on libata).
Comment 1 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2007-07-26 07:49:16 UTC
Created attachment 126048 [details, diff]
0002-Add-customized-modules_load-support.patch
Comment 2 Chris Gianelloni (RETIRED) gentoo-dev 2008-02-26 00:45:18 UTC
*** Bug 154047 has been marked as a duplicate of this bug. ***
Comment 3 Chris Gianelloni 2008-11-03 12:37:48 UTC
I think I'd prefer do this in a configuration file.  In fact, I was thinking more of making a genkernel.conf option for allowing someone to do just this, but for both the modules_load file or the individual MODULES_* variables.  Something like...

MODULES_LOAD_PATH (unset uses default)
OVERRIDE_MODULE_VARS=[y/N]

Setting OVERRIDE_MODULES_VARS should allow a user to set one (or more) of the MODULES_* variables in genkernel.conf, itself.  I'd love it if the contents of the variables were "stackable" using make.conf-like rules, but I'd be perfectly happy with simply forcing the user to put all the modules they want for each variable and pushing the stacking support off until some time later.  The override should only override variables that are explicitly listed.  The rest are pulled from the normal modules_load file(s).

How does that sound?
Comment 4 Andrew Gaffney (RETIRED) gentoo-dev 2008-11-15 06:53:45 UTC
I personally think this patch is fine as-is. It's a very simple approach that should work for pretty much everyone.

We could even extend it a bit to allow for loading multiple files (for i in ${MODULES_CONFIG}; do source ${i}; done). It won't do stacking within the individual vars, but it will allow "inheriting" from previous files, so you can just redefine the var you want.
Comment 5 Xake 2009-11-04 10:16:55 UTC
Have something like this being implemented?
I use nouveau-drm, and wanted it for KMS-goodies loaded already during initramdisk-phase, but I only want the nouveau-module, the other ones I have compiled are not needed that early in the boot process...
Comment 6 Sebastian Pipping gentoo-dev 2011-01-05 22:38:50 UTC
PS: Adding keyword "Inclusion" to better show this bugs nature in searches...
Comment 7 Marc Richter 2012-08-22 10:11:57 UTC
... open since 2007-07-26, last discussed on 2008-11-15 ... why, why, WHY does Gentoo take soooo long to implement existing solutions like this _always_??
Comment 8 Xake 2012-08-23 01:05:42 UTC
(In reply to comment #7)
> ... open since 2007-07-26, last discussed on 2008-11-15 ... why, why, WHY
> does Gentoo take soooo long to implement existing solutions like this
> _always_??

Show me the existing solution. We have a 5 year old patch that probably does not even apply cleanly against genkernel anymore.
And it seems like there was a light argue about if that patch had the right approach among the former maintainers of genkernel, which probably lead to them never applying it in the first case.

So maybe try the patch out, and help port it so it works against the current genkernel codebase?
Because honestly. Your message killed all motivation I could possibly find to work on this feature request. So either hope someone else find the motivation, or come back later and try a little more friendly bump about this feature request.
Comment 9 Sebastian Pipping gentoo-dev 2012-08-24 22:58:10 UTC
(In reply to comment #7)
> ... open since 2007-07-26, last discussed on 2008-11-15 ... why, why, WHY
> does Gentoo take soooo long to implement existing solutions like this
> _always_??

genkernel is quite complex, we are understaffed and work without payment in our spare time.  I can assure you that Debian's initramfs generator has open long standing, bugging issues, too.  Not too pick at Debian, just to put this in relation.
Comment 10 mihalych 2013-05-07 09:16:51 UTC
Created attachment 347578 [details, diff]
Add support MODULES_* override from /etc/genkernel.conf for genkernel 3.4.45 version
Comment 11 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2017-01-03 05:06:09 UTC
Yes, 9.5 years later, I have come back to my patch, and re-implemented it!

[master 5745d52] Allow complete override of MODULES_*
 2 files changed, 24 insertions(+), 3 deletions(-)