Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 186409 - app-portage/gentoolkit - eclean -d deletes needed distfiles with ~ in filename
Summary: app-portage/gentoolkit - eclean -d deletes needed distfiles with ~ in filename
Status: RESOLVED FIXED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Tools (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Portage Tools Team
URL:
Whiteboard:
Keywords: InVCS
Depends on:
Blocks: 170220
  Show dependency tree
 
Reported: 2007-07-24 01:44 UTC by Matthias
Modified: 2007-07-27 21:39 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Matthias 2007-07-24 01:44:32 UTC
eclean -d deletes 2 needed distfiles for openoffice-2.2.1 that must be refetched everytime after i cleanup my distfiles directory and choose to rebuild openoffice-2.2.1.

these files are :

libwpg-0.1.0~cvs20070608.tar.gz
libwps-0.1.0~svn20070129.tar.gz

emerge -pv openoffice lists the following info :

[ebuild   R   ] app-office/openoffice-2.2.1  USE="branding cairo cups gtk pam sound webdav -binfilter -dbus -debug -eds -firefox -gnome -gstreamer -java -kde -ldap -mono -odk -seamonkey" LINGUAS="de en -af -ar -as_IN -be_BY -bg -bn -br -bs -ca -cs -cy -da -dz -el -en_GB -en_US -en_ZA -eo -es -et -fa -fi -fr -ga -gl -gu_IN -he -hi_IN -hr -hu -it -ja -km -ko -ku -lt -lv -mk -ml_IN -mr_IN -nb -ne -nl -nn -nr -ns -or_IN -pa_IN -pl -pt -pt_BR -ru -rw -sh_YU -sk -sl -sr_CS -ss -st -sv -sw_TZ -ta_IN -te_IN -tg -th -ti_ER -tn -tr -ts -uk -ur_IN -ve -vi -xh -zh_CN -zh_TW -zu" 804 kB 


I admit its is a strange bug. I think it is an error in the ebuild of openoffice-2.2.1. No other problems like this on my customized system.



Reproducible: Always

Steps to Reproduce:
1.emerge -f openoffice
2.eclean -dp distfiles OR eclean -d distfiles
3.

Actual Results:  
deleted distfiles as desribed

Expected Results:  
not deleted these 2 needed files
Comment 1 Jakub Moc (RETIRED) gentoo-dev 2007-07-24 06:49:52 UTC
# this regexp extracts files names from SRC_URI. It is not very precise,
# but we don't care (may return empty strings, etc.), since it is fast.
        file_regexp = re.compile('([a-zA-Z0-9_,\.\-\+]*)[\s\)]')

So, if you replace ~ with - in the filename and ebuild, it should work...
Comment 2 Paul Varner (RETIRED) gentoo-dev 2007-07-24 16:33:19 UTC
$ svn commit -m "Fix bug #186409, where eclean was removing files with a ~ character"
Sending        eclean/eclean
Transmitting file data .
Committed revision 422.

Jakub, thanks for the pointer. I've added ~ to the list of valid characters.
Comment 3 Paul Varner (RETIRED) gentoo-dev 2007-07-27 21:39:54 UTC
Released in gentoolkit-0.2.4_pre6