Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 184903 - net-dialup/fritzcapi doesn't work with kernel 2.6.22
Summary: net-dialup/fritzcapi doesn't work with kernel 2.6.22
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo Dialup Developers
URL:
Whiteboard:
Keywords:
: 190152 (view as bug list)
Depends on:
Blocks: kernel-2.6.22
  Show dependency tree
 
Reported: 2007-07-10 21:38 UTC by Sven
Modified: 2007-12-12 20:52 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
fritzcapi-2.6.22.patch (fritzcapi-2.6.22.patch,2.37 KB, text/plain)
2007-07-11 05:58 UTC, Sven
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Sven 2007-07-10 21:38:06 UTC
Hi,

i'm using the fcpci module supplied by fritzcapi ebuild.
it compiles fine (with some warning about implicit declaration of pci_module_init) but then it fails to load. dmesg says:

fcpci: Unknown symbol pci_module_init

besides fcpci, other modules supplied by fritzcapi ebuild may be affected.
Comment 1 Matthias Schwarzott gentoo-dev 2007-07-10 21:59:18 UTC
pci_module_init disappeared with kernel 2.6.22 and should be replaced by pci_register_driver.

Can you please try if just exchanging them works?
Comment 2 Sven 2007-07-11 05:36:33 UTC
in pci.h of kernel 2.6.21, i found this line:

#define pci_module_init pci_register_driver


So i think, we can be pretty sure, that it would work. I haven't tested yet, though. I will try to write a patch. (But don't wait for me ...)
Comment 3 Sven 2007-07-11 05:58:15 UTC
Created attachment 124514 [details]
fritzcapi-2.6.22.patch

patch for kernel 2.6.22 and above
Comment 4 Sven 2007-07-11 05:59:10 UTC
The attached patch can be used to make fritzcapi work with 2.6.22.

Actually i'm running the patched fcpci module right now.
Comment 5 Daniel Drake (RETIRED) gentoo-dev 2007-07-11 22:52:41 UTC
Patch looks good.
Comment 6 Stefan Schweizer (RETIRED) gentoo-dev 2007-07-11 23:04:38 UTC
thank you, added to portage.
Comment 7 Sven 2007-07-12 00:37:44 UTC
Maybe, to ensure backwards compatibility, the patch should only be applied if the kernel version is >= 2.6.22 ?
(the kernel eclass offers some assistance in comparing versions, doesn't it?)
Comment 8 Daniel Drake (RETIRED) gentoo-dev 2007-07-28 16:56:43 UTC
The patch is fine to apply unconditionally. pci_register_driver has been available for a very long time.
Comment 9 Matthias M Weber 2007-08-15 09:30:06 UTC
(In reply to comment #8)

The patch or ebuild doesn't seem to work for amd64 systems. The fritzcapi package compiles but doesn't work because the patch 2.6.22 patch isn't applied for amd64 systems. 

Comment 10 Jakub Moc (RETIRED) gentoo-dev 2007-08-25 08:16:18 UTC
*** Bug 190152 has been marked as a duplicate of this bug. ***
Comment 11 Jakub Moc (RETIRED) gentoo-dev 2007-08-25 08:16:53 UTC
Reopen; why is this applied on x86 only?
Comment 12 apost1 2007-08-25 09:20:20 UTC
The patch that I added in bug 190152 also works for amd64 and checks for the kernel number being greater equal 2.6.22.
Comment 13 Jan Hübner 2007-08-29 12:53:46 UTC
I still get:

fcpci: Unknown symbol pci_module_init

on an AMD64 System and kernel 2.6.22-gentoo-r2. Did my last sync today (29.08.07)
Comment 14 Stefan Schweizer (RETIRED) gentoo-dev 2007-08-29 18:45:30 UTC
ok, I added the fcpci only amd64 patch from 190152 for now. Feel free to contribute the same for the other drivers :)