Bug 176784 – Change java-vm-2.eclass to pull in java-config-1.3 only when vm supports generation 1

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Petteri Räty (RETIRED) 2007-05-02 10:22:56 UTC]

When generation 1 is gone from the tree we should only pull in java-config-1.3 when the JDK supports it. Currently it pulls in both 2.0 and 1.3:
 
betelgeuse@aria ~ $ cat /var/cache/edb/dep/usr/portage/dev-java/sun-jdk-1.5.0.11-r1  | grep RDEPEND
RDEPEND=sys-libs/glibc alsa? ( media-libs/alsa-lib ) doc? ( =dev-java/java-sdk-docs-1.5.0* ) X? ( x11-libs/libX11 x11-libs/libXext x11-libs/libXi x11-libs/libXp x11-libs/libXt ) =dev-java/java-config-2.0* =dev-java/java-config-1.3*

[Comment 1 Josh Nichols (RETIRED) 2007-05-19 02:34:16 UTC]

I think we had it like that at one point, but ended up with some issues back when the new java system was unleashed on the masses.

Here's the situation as I recall:

Say you emerge virtual/jdk. You'd probably get sun-jdk-1.5 or 1.6, which both only support gen-2.

So, you wouldn't get java-config-1.3

At some point, you are recommended to run java-check-environment. At some point, ti probably recommends you java-config-1. But, you only have java-config-2


Now, I'm not positive if this is still accurate or not. If we do want to go ahead with this, I think we'd want to do a bit of testing from 'fresh' installs vs upgrades from pre gen-2, to make sure we get the right results.

[Comment 2 Vlastimil Babka (Caster) (RETIRED) 2009-01-07 21:46:49 UTC]

*** Bug 253982 has been marked as a duplicate of this bug. ***

[Comment 3 Vlastimil Babka (Caster) (RETIRED) 2009-01-07 21:50:53 UTC]

Dep was added to eclass for bug 151459. If java-check-environment is the only reason, that's bug 176782. Maybe there's more, but I can't remember.

[Comment 4 Patrizio Bassi 2009-01-08 08:21:44 UTC]

i could manage to have a java6 only environment.

i don't need 1.4 and 1.5 so i don't see the need of a java-config 1.3 for generation 2 jdk.

please drop the deps.

[Comment 5 Vlastimil Babka (Caster) (RETIRED) 2009-02-10 00:55:20 UTC]

Done:

--- java-vm-2.eclass    8 Feb 2009 21:42:27 -0000       1.24       
+++ java-vm-2.eclass    9 Feb 2009 22:53:51 -0000                  
@@ -18,8 +18,13 @@                                                 
        =dev-java/java-config-2*                                   
        >=sys-apps/portage-2.1"                                    
 RDEPEND="                                                         
-       =dev-java/java-config-2*                                   
-       =dev-java/java-config-1.3*"                                
+       =dev-java/java-config-2*"                                  
+                                                                  
+# bug #176784                                                     
+if [[ ${JAVA_SUPPORTS_GENERATION_1} == 'true' && ${JAVA_VM_NO_GENERATION1} != 'true' ]]; then
+       DEPEND="${DEPEND} =dev-java/java-config-1.3*"                                         
+       RDEPEND="${RDEPEND} =dev-java/java-config-1.3*"                                       
+fi                                                                                           
                                                                                

Soon we'll drop java-config-1.3 dep altogether I guess.