The bash completion for the svn and svnadmin commands in /etc/bash_completion are somewhat outdated. Especially when expanding a directory name, there is a trailing space instead of a slash. For a long time I thought this an issue with the subversion tarball, and it was only now I found out that /usr/share/bash-completion/* will not be sourced automatically and that I had not symlinked the subversion script. Having the expansions for the same command in multiple places is bound to cause confusion, and the one that comes with subversion is definitely superior to the one in bash-completion. So I suggest removing the latter. On the whole, it is a bit strange that bash_completion will autodetect so many programs and then install completions for them automatically, while the files in /usr/share/bash-completion/ have to be enabled manually, even though it is known the command is present, and in most cases the ebuild was emerged with the bash-completion USE flag, so in most cases the user would want the completion.
I'm really puzzled which outdated commands are you talking about. The only ones I could find are installed via subversion ebuild, not with app-shells/bash-completion itself... ???
(In reply to comment #1) > I'm really puzzled which outdated commands are you talking about. The only > ones I could find are installed via subversion ebuild, not with > app-shells/bash-completion itself... ??? As I said, it's in /etc/bash_completion itself which the ebuild installed using "insinto /etc" and "doins bash_completion". I just made sure this is really part of the upstream file, and not just some local modification. In that file lines 8811 through 9233 are completion functions for svn, svnadmin and svnlook. To my surprise the ebuild does "rm contrib/subversion" while I can't find such a file in the tarball, as all functions are not in contrib but in the main script.
(In reply to comment #2) > As I said, it's in /etc/bash_completion itself which the ebuild installed using > "insinto /etc" and "doins bash_completion". Which ebuild? We don't install anything to /etc/bash_completion, only the symlinks go there. $ equery f bash-completion | grep /etc /etc /etc/bash_completion /etc/profile.d /etc/profile.d/bash-completion
(In reply to comment #3) > Which ebuild? app-shells/bash-completion-20060301 (not -r2) as I wrote in the summary. > We don't install anything to /etc/bash_completion, only the > symlinks go there. > > $ equery f bash-completion | grep /etc > /etc/bash_completion But there it is! And the commands I quoted from the ebuild in comment #2 do install this. # qfile -v /etc/bash_completion app-shells/bash-completion-20060301 (/etc/bash_completion)
app-shells/bash-completion-20081218 provides a new subversion completion. Now we should decide which subversion completion provide (builtin version or subversion's one), right now both are provided. Feedback is welcome.
app-shells/bash-completion-20081218 doesn't provide completion for some Subversion subcommands (e.g. 'svn mergeinfo', 'svn resolve'). dev-util/subversion should still provide completion.
Hello, the new upstream version of bash-completion is going to fix this. I've split up subversion-related completions (i.e. svn, svnlook and svnadmin, IIRC) to contrib/subversion, so you guys can choose which one to use :) Kindly, David Paleino Bash-Completion Team
I'm only seeing subversion completion coming from dev-util/subversion (and it completes resolve and mergeinfo). Since the pending stable req for bash-completion-20081218 is coming this week I can't find anything to fix here. Please respond asap if I am incorrect
(In reply to comment #8) > I'm only seeing subversion completion coming from dev-util/subversion (and it > completes resolve and mergeinfo). Since the pending stable req for > bash-completion-20081218 is coming this week I can't find anything to fix here. > Please respond asap if I am incorrect $ qlist bash-completion | xargs grep svn tells me that /usr/share/bash-completion/base from bash-completion-20081218 still provides svn autocompletion, and that version is still outdated. So the issue remains. I suggest simply remove the whole "have svn && { ... }" block, and let subversion deal with it.
The issue was solved upstream just after I took 20081218 snapshot. It should be ok to put a 20081219 tarball in portage.
(In reply to comment #10) > The issue was solved upstream just after I took 20081218 snapshot. It should be > ok to put a 20081219 tarball in portage. > Ohh, I see now. svn completion is in base. Right. This will block stabilization of 20081218-r1. I'll get a 20081219 snapshot in the tree. The only changes will be this subversion stuff. thx
Fixed in 20081219 - now in tree. Please re-open bug if needed. Thanks. Fixed in stable tree in ~week or so, please test this and report any issues asap. =)
