First Last Prev Next    No search results available      Search page      Enter new bug
Bug#: 169599
Alias:
Product:
Component:
Status: RESOLVED
Resolution: FIXED
Assigned To: Gentoo Security <security@gentoo.org>
Hardware:
OS:
Version:
Priority:
Severity:
Reporter: Frank Benkstein <benkstein@gmx.de>
Add CC:
CC:
Remove selected CCs
URL:
Summary:
Status Whiteboard:
Keywords:
Flags: Requestee:
 
 
  ()

Filename Description Type Creator Created Size Actions
silc-join-hmac.patch silc-join-hmac.patch patch Frank Benkstein 2007-03-06 11:49 0000 1.11 KB Details | Diff
silc-join-hmac-v2.patch silc-join-hmac-v2.patch text/plain Frank Benkstein 2007-03-06 12:43 0000 2.81 KB Details
Create a New Attachment (proposed patch, testcase, etc.) View All

Bug 169599 depends on: Show dependency tree
Bug 169599 blocks:

Additional Comments: (this is where you put emerge --info)


Not eligible to see or edit group visibility for this bug.






View Bug Activity   |   Format For Printing   |   XML   |   Clone This Bug

Description:   Opened: 2007-03-06 11:47 0000 
Hi,

there is a bug in the current version of silc-server that makes it possible
to crash a networks SILC router, when a new channel is created. All it takes
is to specify an invalid hmac algorithm name and no cipher algorithm name.
This results in an null pointer dereference in 'SILC_SERVER_CMD_FUNC(join)' at
line 2444 in apps/silcd/command.c.

The attached patch fixes the problem.

Best regards,
Frank Benkstein

------- Comment #1 From Frank Benkstein 2007-03-06 11:49:07 0000 ------- 
Created an attachment (id=112279) [details]
silc-join-hmac.patch

silc_server_create_new_channel failing may mean a number of things. Before
the patch silcd just assumes that the cipher algorithm was not found (which
may not even be provided).

------- Comment #2 From Matthias Geerdsen 2007-03-06 12:04:06 0000 ------- 
thanks for the report

net-irc can you comment/confirm? tavis?

------- Comment #3 From Frank Benkstein 2007-03-06 12:43:43 0000 ------- 
Created an attachment (id=112281) [details]
silc-join-hmac-v2.patch

The error described before may happen at multiple places. The previous patch
only fixed the issue for standalone servers and not for routers.

------- Comment #4 From Raúl Porcel 2007-03-06 13:49:54 0000 ------- 
Yep, i was able to reproduce the bug. The patch fixes it.

silc-server-1.0.2-r1 commited to the tree :)

------- Comment #5 From Matthias Geerdsen 2007-03-06 14:04:26 0000 ------- 
thanks Raúl

arches, please test silc-server-1.0.2-r1 and mark stable if possible

------- Comment #6 From Raúl Porcel 2007-03-06 14:31:15 0000 ------- 
x86 stable.

Btw, thanks Frank for the patch(forgot to say before)

------- Comment #7 From Tobias Scherbaum 2007-03-06 20:04:11 0000 ------- 
ppc stable

------- Comment #8 From Frank Benkstein 2007-03-07 08:50:44 0000 ------- 
FYI: silc-server 1.0.3 was just released, including this fix

------- Comment #9 From Gustavo Zacarias (RETIRED) 2007-03-07 14:18:36 0000 ------- 
sparc stable.

------- Comment #10 From Matthias Geerdsen 2007-03-07 14:26:24 0000 ------- 
voting time

/me votes yes

------- Comment #11 From Stefan Cornelius (RETIRED) 2007-03-07 14:35:24 0000 ------- 
yes++

------- Comment #12 From Matthias Geerdsen 2007-03-14 13:00:38 0000 ------- 
GLSA 200703-12

thanks everyone
First Last Prev Next    No search results available      Search page      Enter new bug