Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 169039 - >app-editors/emacs-cvs-22.0.93-r2 does not make desktop entry anymore
Summary: >app-editors/emacs-cvs-22.0.93-r2 does not make desktop entry anymore
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Emacs project
URL:
Whiteboard: Emacs Overlay
Keywords: InOverlay
: 172100 (view as bug list)
Depends on:
Blocks:
 
Reported: 2007-03-02 19:29 UTC by Christian Schlotter
Modified: 2007-04-17 06:09 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Christian Schlotter 2007-03-02 19:29:47 UTC
Hi!

I noticed that since emacs-cvs-22.0.94 no desktop entry was created anymore.  I did not find a reason for this in the ChangeLog, so I think this happend unintentionally.  The patch below reverts this behaviour.  I ommited the "type" argument to make_desktop_entry because this is detected automatically from the app-editors category.

Best regards
Christian 

--- /usr/portage/app-editors/emacs-cvs/emacs-cvs-22.0.95.ebuild 2007-03-02 08:16:59.000000000 +0100
+++ emacs-cvs-22.0.95.ebuild    2007-03-02 20:27:23.000000000 +0100
@@ -170,6 +170,9 @@
                find ${D} -type f -name \*.el.gz -print0 |xargs -0 gunzip
        fi
        dodoc BUGS ChangeLog README
+
+       make_desktop_entry /usr/bin/emacs "GNU Emacs" \
+               /usr/share/emacs/${SLOT}/etc/images/icons/emacs_48.png
 }
 
 update-alternatives() {
Comment 1 Christian Faulhammer (RETIRED) gentoo-dev 2007-03-02 19:34:04 UTC
That was intended, I just forgot to mention it in the ChangeLog.  make_desktop_entry won't work the way we need it, and I was too lazy to create own logic to provide one.  Is it really needed from your side?
Comment 2 Christian Schlotter 2007-03-02 19:45:52 UTC
Is don't absolutely need it.  It was just a minor convenience to have Emacs in Gnome's application menu -- so, if it didn't work the way we need it...
Comment 3 Christian Faulhammer (RETIRED) gentoo-dev 2007-03-02 19:58:21 UTC
As talked about on IRC.  Closing.
Comment 4 Christian Faulhammer (RETIRED) gentoo-dev 2007-03-25 11:15:33 UTC
Just for your information: The files in Emacs Overlay will have a proper desktop file for all Emacs versions.
Comment 5 Christian Faulhammer (RETIRED) gentoo-dev 2007-03-25 11:16:00 UTC
*** Bug 172100 has been marked as a duplicate of this bug. ***
Comment 6 Christian Faulhammer (RETIRED) gentoo-dev 2007-04-06 10:52:16 UTC
It will be fixed as soon as Emacs overlay's ebuilds make it to the tree
Comment 7 Ulrich Müller gentoo-dev 2007-04-17 06:09:27 UTC
Fixed in 22.0.98, 22.0.9999-r10, and 23.0.0-r6, thanks for reporting.

(In case you are not on x86: keywording for the other architectures will follow, please have some patience.)