Bug 167486 – gnome-extra/libgsf-1.14.2 preserve_old_lib() must be called from pkg_preinst() only

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Caleb Cushing 2007-02-18 15:32:48 UTC]

I was rebuilding world. libgsf stopped building with this error.

 * preserve_old_lib() must be called from pkg_preinst() only

a little farther down it says (in the call stack)
libgsf-1.14.2.ebuild, line 39:   Called preserve_old_lib '/usr/lib/libgsf-1.so.1'
 

Reproducible: Always

[Comment 1 Caleb Cushing 2007-02-18 15:34:35 UTC]

Created attachment 110546 [details]
emerge --info

[Comment 2 Caleb Cushing 2007-02-18 15:37:58 UTC]

Created attachment 110547 [details]
libgsf emerge log

[Comment 3 Christoph Kappel 2007-02-18 16:16:54 UTC]

Created attachment 110552 [details, diff]
Fix the preserve_old_lib() bug

It's easy to fix - so it should hopefully be upstream soon. 
The attached patch works for me.
Additionally there's a QA notice about poor programming:

 * QA Notice: Package has poor programming practices which may compile
 *            fine but exhibit random runtime failures.
 * gsfmodule.c:40: warning: implicit declaration of function 'pygsf_register_classes

[Comment 4 Caleb Cushing 2007-02-18 16:28:12 UTC]

heh... good thing I don't use gnome. I just use a few things that depends on some of there stuff (e.g. gdm, gaim) somewhere along the line this must be a dependancy.but thx for the quick fix.

[Comment 5 Jakub Moc (RETIRED) 2007-02-18 18:09:54 UTC]

Kindly review http://bugs.gentoo.org/page.cgi?id=fields.html#bug_severity

[Comment 6 Jakub Moc (RETIRED) 2007-02-18 18:33:19 UTC]

*** Bug 167485 has been marked as a duplicate of this bug. ***

[Comment 7 Samuli Suominen (RETIRED) 2007-02-18 18:41:08 UTC]

fix0red, thanks for reporting..

[Comment 8 Daniel Gryniewicz (RETIRED) 2007-02-18 22:44:15 UTC]

As drac said, fixed.

[Comment 9 Caleb Cushing 2007-02-19 02:23:59 UTC]

is this patch going to get committed to portage? (fixed my problem but I put it in an overlay)

[Comment 10 Daniel Gryniewicz (RETIRED) 2007-02-19 02:37:16 UTC]

It's been in portage for 8 hours now.

[Comment 11 Daniel Gryniewicz (RETIRED) 2007-02-19 21:47:34 UTC]

*** Bug 167593 has been marked as a duplicate of this bug. ***