Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 166374 - dev-libs/glib-1.2.10 header file glibconfig.h messed up
Summary: dev-libs/glib-1.2.10 header file glibconfig.h messed up
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Library (show other bugs)
Hardware: All All
: High normal (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-02-11 17:26 UTC by Daniel Glöckner
Modified: 2007-03-03 16:07 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Restore newlines in configure.in (patch-for-glib-1.2.10-as-needed.patch,575 bytes, patch)
2007-02-17 16:58 UTC, Olivier Dembour
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Glöckner 2007-02-11 17:26:23 UTC
glib-1.2.10-as-needed.patch contains this hunk:

--------------------------------------------------------
--- glib-1.2.10/configure.in.orig       2006-05-24 01:22:02.000000000 -0700
+++ glib-1.2.10/configure.in    2006-05-24 01:28:59.000000000 -0700
@@ -1235,9 +1234,7 @@
 #  define G_GNUC_EXTENSION __extension__
 #else
 #  define G_GNUC_EXTENSION
-#endif
-
-"
+       #endif"
   gint64_constant='(G_GNUC_EXTENSION (val##LL))'
   ;;
 esac
--------------------------------------------------------

It results in /usr/lib/glib/include/glibconfig.h containing the line:

--------------------------------------------------------
        #endif#define G_HAVE_GINT64 1
--------------------------------------------------------

GCC only warns about that line containing junk after #endif, but f.ex. wireshark fails to build because G_HAVE_GINT64 remains undefined.

The hunk should be deleted from the patch.

Reproducible: Always
Comment 1 Olivier Dembour 2007-02-17 16:58:49 UTC
Created attachment 110478 [details, diff]
Restore newlines in configure.in

glib-1.2.10-as-needed.patch delete needed newlines in configure.in. The generated glibconfig.h was corrupted on line 38 like this :

#else
#  define G_GNUC_EXTENSION
#endif#define G_HAVE_GINT64 1
Comment 2 Raphael Marichez (Falco) (RETIRED) gentoo-dev 2007-03-03 16:07:53 UTC
thanks Daniel and Olivier, and leio who helped me, it should be fixed now.

If you have emerged glib-1 between Fév 03 and March 03, then you have to reemerge glib to fix your header files.