Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 164518 - app-laptop/hdapsd pkg_config() looking for wrong patches
Summary: app-laptop/hdapsd pkg_config() looking for wrong patches
Status: RESOLVED DUPLICATE of bug 166166
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Peter Weller (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 187154
  Show dependency tree
 
Reported: 2007-01-30 10:04 UTC by René 'Necoro' Neumann
Modified: 2009-10-14 21:48 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Changed ebuild (hdapsd-20060409-r1.ebuild,2.28 KB, text/plain)
2007-01-30 10:05 UTC, René 'Necoro' Neumann
Details
Changed hdapsd-20060409-r1.ebuild (hdapsd-20060409-r1.ebuild,2.48 KB, text/plain)
2007-05-23 05:50 UTC, René 'Necoro' Neumann
Details
hdapsd ebuild now installing to /usr/share (hdapsd-ebuild.diff,1.18 KB, patch)
2007-10-16 14:42 UTC, René 'Necoro' Neumann
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description René 'Necoro' Neumann 2007-01-30 10:04:39 UTC
The current hdapsd pkg_config() is looking for the patches as .gz, but they are supplied as .bz2 ...

Find the changed ebuild appended...
Comment 1 René 'Necoro' Neumann 2007-01-30 10:05:24 UTC
Created attachment 108601 [details]
Changed ebuild
Comment 2 Anton Bolshakov 2007-05-22 04:01:54 UTC
I don't think it should be .bz2 as you suggested because ebuild will unpack hdaps_protect-patches-2.tar.bz2 for you. However, I don't understand why the current ebuild (with *.gz) works fine. May be because gzip just skips it since it's not gzip archive.
IMHO, it should be no extention at all.
I'm not an expert in this :\
Comment 3 René 'Necoro' Neumann 2007-05-22 06:20:49 UTC
(In reply to comment #2)
> I don't think it should be .bz2 as you suggested because ebuild will unpack
> hdaps_protect-patches-2.tar.bz2 for you.

It is not about the "hdaps_protect-patches-2.tar.bz2", but the single patches itself, which are supplied as "*.patch.bz2". If you run "emerge --config =hdaps-<yourversion>" with the current ebuild, it will say you, that it cannot find the patches, because it is looking for "*.patch.gz".

(Just do an "ls /usr/share/doc/hdapsd-<yourversion>/" ;))
Comment 4 Anton Bolshakov 2007-05-22 08:25:51 UTC
that where it comes from!
ok,
here is my listing:
# ls -al /usr/share/doc/hdapsd-20060409-r1/
total 44
drwxr-xr-x   2 root root   232 2006-12-05 23:40 .
drwxr-xr-x 461 root root 15928 2007-05-22 04:09 ..
-rw-r--r--   1 root root  6354 2006-12-05 23:40 hdaps_protect-2.6.17.patch.gz
-rw-r--r--   1 root root  6571 2006-12-05 23:40 hdaps_protect-2.6.18.patch.gz
-rw-r--r--   1 root root  6838 2006-12-05 23:40 hdaps_protect-2.6.19.patch.gz
-rw-r--r--   1 root root   226 2006-12-05 23:40 hdaps-Z60m.patch.gz

do you have it bz2-ed?..
Comment 5 René 'Necoro' Neumann 2007-05-22 19:02:32 UTC
% ls -al /usr/share/doc/hdapsd-20060409-r1/
insgesamt 48
drwxr-xr-x   2 root root  4096  7. Mai 12:07 .
drwxr-xr-x 537 root root 16384 21. Mai 14:06 ..
-rw-r--r--   1 root root  6075  7. Mai 12:07 hdaps_protect-2.6.17.patch.bz2
-rw-r--r--   1 root root  6244  7. Mai 12:07 hdaps_protect-2.6.18.patch.bz2
-rw-r--r--   1 root root  6522  7. Mai 12:07 hdaps_protect-2.6.19.patch.bz2
-rw-r--r--   1 root root   260  7. Mai 12:07 hdaps-Z60m.patch.bz2

Yeah ... hmm ... *astonished* ... strange
Comment 6 René 'Necoro' Neumann 2007-05-23 05:50:55 UTC
Created attachment 120051 [details]
Changed hdapsd-20060409-r1.ebuild

I had a look inside what dodoc and then ecompress are doing. And ecompress is using the variable "PORTAGE_COMPRESS" to determine, which suffix to use. I made the ebuild to do so too.

But: I think it is a wrong way to store these patches inside "/usr/share/doc" - wouldn't "/usr/share" be a better place? - And there they would not be compressed and thus the above hack would be obsolete.
Comment 7 Jakub Moc (RETIRED) gentoo-dev 2007-08-24 14:40:36 UTC
(In reply to comment #6)
> But: I think it is a wrong way to store these patches inside "/usr/share/doc" -
> wouldn't "/usr/share" be a better place? - And there they would not be
> compressed and thus the above hack would be obsolete.

Yeah, that's definitely completely wrong location. 

Comment 8 René 'Necoro' Neumann 2007-10-16 14:42:38 UTC
Created attachment 133621 [details, diff]
hdapsd ebuild now installing to /usr/share

Changed the current ebuild (not the one already attached here) to install into /usr/share/${PN} instead of /usr/share/doc.

=)
Comment 9 Anton Bolshakov 2008-06-17 02:48:19 UTC
Hi,

I've uploaded complete set of ebuils+patches (including tp_smapi with udev rule) to my sectools overlay:
http://gentoo.o0o.nu/sectools.xml
the latest hdapsd.ebuild (+files) can be find here:
http://gentoo.o0o.nu/portage/app-laptop/hdapsd/

Check it out and let me know if any problem
Comment 10 Thilo Bangert (RETIRED) (RETIRED) gentoo-dev 2009-10-14 21:48:17 UTC
concentrating all work on new hdapsd on one bug. thanks for the report - sorry for the delay.

*** This bug has been marked as a duplicate of bug 166166 ***