Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 163068 - make app-portage/deltup-0.4.3_pre2 compatible with bzip2-1.0.4
Summary: make app-portage/deltup-0.4.3_pre2 compatible with bzip2-1.0.4
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All All
: High normal (vote)
Assignee: Stefan Schweizer (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-01-21 14:48 UTC by Igor V. Kovalenko
Modified: 2007-02-06 10:31 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
patch to check for bzip2 >= 1.0.3 (deltup-bzip2-v104.patch,548 bytes, patch)
2007-01-21 14:49 UTC, Igor V. Kovalenko
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Igor V. Kovalenko 2007-01-21 14:48:36 UTC
See also http://bugs.gentoo.org/show_bug.cgi?id=89475 about original problem with bzip2 implementation changes and checksum errors, and http://bugs.gentoo.org/show_bug.cgi?id=160283 about bzip2-1.0.4 availablilty.

It is clear that original intention of fix available in deltup sources (concerning bzip2 algorithm changes in bzip2-1.0.3) was to treat all bzip2 versions >= 1.0.3 as "new format". Seems like there is a typo in implementation of that fix, which introduces strict matching for bzip2-1.0.3 version and makes bzip2-1.0.4 a problem. Solution is to match for ">=1.0.3" version (one-liner).

Patch attached, please apply (while upstream fix is not available).


Reproducible: Always

Steps to Reproduce:
Prepare:
1. Follow http://gentoo-wiki.com/TIP_Gentoo_for_dialup_users to set up getdelta.sh to fetch package changes via deltup.
2. install bzip2-1.0.4 package

Reproduce e.g. with libX11 update:
3. make sure /usr/portage/distfiles/libX11-1.0.3.tar.bz2 is the latest libX11 package available, and portage tree has x11-libs/libX11-1.1.1 so you have an upgrade and need to download new source
4. emerge -f libX11 

Actual Results:  
libX11-1.0.3.tar.bz2-libX11-1.1.1.tar.bz2.dtu is found and applied without errors, resulting in libX11-1.1.1.tar.bz2 package
in the process deltup reports that bzip2_old is used for recompression (which is bad, because dtu file requires at least bzip2-1.0.3)

portage refuses the result because of checksum mismatch


Expected Results:  
libX11-1.0.3.tar.bz2-libX11-1.1.1.tar.bz2.dtu is found and applied without errors, resulting in libX11-1.1.1.tar.bz2 package
in the process deltup reports that bzip2 is used for recompression (which is now OK, bzip2-1.0.4 is correctly used)

portage accepts the result, checksums are OK
Comment 1 Igor V. Kovalenko 2007-01-21 14:49:30 UTC
Created attachment 107673 [details, diff]
patch to check for bzip2 >= 1.0.3
Comment 2 Stefan Schweizer (RETIRED) gentoo-dev 2007-02-06 10:31:49 UTC
already fixed in -r1, thank you very much for reporting and fixing this!