160795 – media-libs/smpeg-0.4.4-r8 Segfault caused by missing initialisation

Bug 160795 - media-libs/smpeg-0.4.4-r8 Segfault caused by missing initialisation

Summary: media-libs/smpeg-0.4.4-r8 Segfault caused by missing initialisation

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	[OLD] Library (show other bugs)
Hardware:	x86 Linux

Importance:	High normal (vote)
Assignee:	Gentoo Games

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2007-01-07 22:46 UTC by Vincent Le Ligeour
Modified:	2007-01-09 09:28 UTC (History)
CC List:	0 users

See Also:
Package list:
Runtime testing required:	---

Attachments
smpeg-0.4.4-missing-init.patch (smpeg-0.4.4-missing-init.patch,266 bytes, patch) 2007-01-07 22:47 UTC, Vincent Le Ligeour	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Vincent Le Ligeour 2007-01-07 22:46:09 UTC

When an non-openable file is given to SMPEG_new, it doesn't return a NULL pointer (this is normal behavior) but the status MPEG class member is not properly initialized. The SMPEG_delete on the object created will then segfault because of a NULL pointer test not initialized.
(can be test with the current ultrastar-ng cvs version)

Reproducible: Always

Steps to Reproduce:
1.Create an SMPEG object with a non-existant file with SMPEG_new
2.Try to delete it with SMPEG_delete




Patched will be attached in the next comment

Comment 1 Vincent Le Ligeour 2007-01-07 22:47:42 UTC

Created attachment 105957 [details, diff]
smpeg-0.4.4-missing-init.patch

Compile fine and patch the bug (patch has been sent to the loki team)

Comment 2 Mr. Bones. (RETIRED) gentoo-dev

2007-01-09 09:28:37 UTC

In portage.  Thanks for the bug report and patch.

It seems like a pretty obscure corner case so I didn't rev bump it.  Remerge for the patch.