Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 158054 (.xvpics) - media-gfx/xv doesn't create .xvpics thumbnail dir without AUTO_EXPAND defined
Summary: media-gfx/xv doesn't create .xvpics thumbnail dir without AUTO_EXPAND defined
Status: RESOLVED DUPLICATE of bug 135304
Alias: .xvpics
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High trivial (vote)
Assignee: Tavis Ormandy (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-12-13 11:14 UTC by mjh
Modified: 2007-01-09 12:16 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description mjh 2006-12-13 11:14:25 UTC 
When xv tries to store thumbnail to disk in directories where .xvpics doesn't already exist it fails to do so as it fails to create .xvpics, therefore forcing you to recreate visible thumbs e.g. when traversing a directorylevel up and down again.

This happens only if AUTO_EXPAND isn't defined.

This behaviour is non standard and introduced by xv-3.10a-jumbo-enh-patch-20050501.txt from xv-3.10a-jumbo-patches-20050501.tar.bz2.

xvbrowse.c gets patched by wrapping mkdir command inside the #ifdef AUTO_EXPAND,  with no #else case:

+#ifdef AUTO_EXPAND
+    Dirtovd(thFname);
+#  ifdef VIRTUAL_TD
+    if (mkdir(thFname, (mode_t) perm) < 0)
+      Mkvdir_force(thFname);
+#  else
     mkdir(thFname, (mode_t) perm);
+#  endif
+#endif

=== adding the #else case fixed it for me:

#ifdef AUTO_EXPAND
    Dirtovd(thFname);
#  ifdef VIRTUAL_TD  
    if (mkdir(thFname, (mode_t) perm) < 0)
      Mkvdir_force(thFname);
#  else
    mkdir(thFname, (mode_t) perm);
#  endif
+#else
+    mkdir(thFname, (mode_t) perm);
+#endif
Comment 1 mjh 2007-01-09 12:16:00 UTC 

*** This bug has been marked as a duplicate of bug 135304 ***