Mail from Josh Coalson : " hi Robert, attached are patches to cuecue-0.2.2 to make the code work with both the upcoming FLAC 1.1.3 release and previous versions. a beta of FLAC 1.1.3 is available here: http://prdownloads.sourceforge.net/flac/flac-1.1.3-beta2.tar.gz?download changelog: http://flac.cvs.sourceforge.net/*checkout*/flac/flac/doc/html/changelog.html the LEGACY_FLAC stuff can be removed once FLAC-1.1.3 has propagated everywhere. note: if your build system is using --with-libFLAC to point at a non-standard place, you will also have to get: http://flac.cvs.sourceforge.net/*checkout*/flac/flac/src/libFLAC/libFLAC.m4 and rerun aclocal with it, then autoconf the patch also should work against svn HEAD as all the files affected are the same. let me know if you have any questions or problems... Josh " Maybe this would help if you want to carefully review the patch : http://flac.sourceforge.net/api/group__porting.html The guideline I've followed to patch sound/video apps is : review and apply the patch test with both flac 1.1.2 & flac 1.1.3 remove the ~ dep on flac 1.1.2 By doing so we'll be able to unmask flac 1.1.3 as soon as the deptree will be correct.
Created attachment 103732 [details, diff] Patch from Josh Coalson
cool. I have a look at it later. thanks!
Can we have this done ? If you want we can apply the patch.
yup. I'll check it right now...
hmm. your patch doesn't compile against 1.1.2. I have to check why...
+ case FLAC__STREAM_DECODER_ERROR_STATUS_UNPARSEABLE_STREAM: + strcpy(cuecue_error,"Unparseable stream"); + internal->error=1; + break; that part wasn't #ifdef'ed.
*-r1 in CVS. Tested against 1.1.2 and 1.1.4 (which is compatible to 1.1.3). Please test and reopen if you encounter an error. Thanks!
