First Last Prev Next    No search results available      Search page      Enter new bug
Bug#: 157587
Alias:
Product:
Component:
Status: RESOLVED
Resolution: FIXED
Assigned To: Gnustep herd <gnustep@gentoo.org>
Hardware:
OS:
Version:
Priority:
Severity:
Reporter: Alexis Ballier <aballier@gentoo.org>
Add CC:
CC:
Remove selected CCs
URL:
Summary:
Status Whiteboard:
Keywords:

Filename Description Type Creator Created Size Actions
Cynthiune-0.9.5+flac-1.1.3.patch Patch from Josh Coalson patch Alexis Ballier 2006-12-09 02:28 0000 8.71 KB Details | Diff
Create a New Attachment (proposed patch, testcase, etc.) View All

Bug 157587 depends on: Show dependency tree
Bug 157587 blocks: 152007
Votes: 0    Show votes for this bug    Vote for this bug

Additional Comments: (this is where you put emerge --info)


Not eligible to see or edit group visibility for this bug.






View Bug Activity   |   Format For Printing   |   XML   |   Clone This Bug


Description:   Opened: 2006-12-09 02:27 0000
This is more to be compatible with flac 1.1.3 than to bump for the sake of
bumping as Josh's patch does not apply to 0.9.4 currently in the tree.

Mail from Josh Coalson : 
"
(cc'ing other package maintainers)
hi Wolfgang, attached is a patch to cyntiune-0.9.5 to make the code
work with both the upcoming FLAC 1.1.3 release and previous
versions.  a beta of FLAC 1.1.3 is available here:
http://prdownloads.sourceforge.net/flac/flac-1.1.3-beta2.tar.gz?download

changelog:
http://flac.cvs.sourceforge.net/*checkout*/flac/flac/doc/html/changelog.html

the LEGACY_FLAC stuff can be removed once FLAC-1.1.3 has propagated
everywhere.

let me know if you have any questions or problems...

Josh
"

Maybe this would help if you want to carefully review the patch : 
http://flac.sourceforge.net/api/group__porting.html


The guideline I've followed to patch sound/video apps is : 
review and apply the patch
test with both flac 1.1.2 & flac 1.1.3
remove the ~ dep on flac 1.1.2


By doing so we'll be able to unmask flac 1.1.3 as soon as the deptree will be
correct.

------- Comment #1 From Alexis Ballier 2006-12-09 02:28:10 0000 -------
Created an attachment (id=103669) [details]
Patch from Josh Coalson

------- Comment #2 From Fabian Groffen 2006-12-09 03:30:19 0000 -------
Problem with this is, is that the latest version of Cynthiune doesn't compile
on Gentoo, since it requires libavi, which Gentoo has punted long ago according
to sound members.  Not being a sound/media person myself I have no idea on how
to fix that.

------- Comment #3 From Alexis Ballier 2006-12-09 03:35:57 0000 -------
I'm gonna have a look at it, the present situation is not acceptable: either
blocking flac 1.1.3 migration or breaking cynthiune

------- Comment #4 From Fabian Groffen 2006-12-09 03:39:08 0000 -------
I think if the libavi dep could be out of cynthiune we'd all be happy.  Since
this blocks you guys at large I guess I'll have to dive into the code too as
soon as I have time to get it working.

------- Comment #5 From Alexis Ballier 2006-12-11 10:14:19 0000 -------
You just need to call:

 egnustep_make "disable-windowsmedia=yes"

in src_compile

and 

egnustep_install "disable-windowsmedia=yes"
in src_install


By doing this it installs in : /usr/GNUstep/Local
I dunno if that's a standard location for gnustep apps, but this prevented me
from running it.

By the way, you can enable/disable a lot of features only by giving
egnustep_{make,install} the correct argument (have a look at the GNUmakefile).
Since it is not automagic dependencies we should take advantage of this by
controlling that via use flags :)

------- Comment #6 From Fabian Groffen 2006-12-11 10:52:29 0000 -------
many thanks!  Committed to portage now.  cynthiune-0.9.5 should now be
flac-safe.

First Last Prev Next    No search results available      Search page      Enter new bug