First Last Prev Next    No search results available      Search page      Enter new bug
Bug#: 157582
Alias:
Product:
Component:
Status: RESOLVED
Resolution: FIXED
Assigned To: Gentoo Games <games@gentoo.org>
Hardware:
OS:
Version:
Priority:
Severity:
Reporter: Alexis Ballier <aballier@gentoo.org>
Add CC:
CC:
Remove selected CCs
URL:
Summary:
Status Whiteboard:
Keywords:

Filename Description Type Creator Created Size Actions
scummvm-0.9.0+flac-1.1.3.patch Patch from Josh Coalson patch Alexis Ballier 2006-12-09 01:57 0000 19.29 KB Details | Diff
Create a New Attachment (proposed patch, testcase, etc.) View All

Bug 157582 depends on: Show dependency tree
Bug 157582 blocks: 152007
Votes: 0    Show votes for this bug    Vote for this bug

Additional Comments: (this is where you put emerge --info)


Not eligible to see or edit group visibility for this bug.






View Bug Activity   |   Format For Printing   |   XML   |   Clone This Bug


Description:   Opened: 2006-12-09 01:54 0000
Mail from Josh Coalson : 
"
hi devs, attached are patches to scummvm-0.9.0 to make the code
work with both the upcoming FLAC 1.1.3 release and previous
versions.  a beta of FLAC 1.1.3 is available here:
http://prdownloads.sourceforge.net/flac/flac-1.1.3-beta2.tar.gz?download

changelog:
http://flac.cvs.sourceforge.net/*checkout*/flac/flac/doc/html/changelog.html

the LEGACY_FLAC stuff can be removed once FLAC-1.1.3 has propagated
everywhere.

the patch also should work against svn HEAD as all the files
affected are the same.

let me know if you have any questions or problems...

Josh
"

Maybe this would help if you want to carefully review the patch : 
http://flac.sourceforge.net/api/group__porting.html


The guideline I've followed to patch sound/video apps is : 
review and apply the patch
test with both flac 1.1.2 & flac 1.1.3
remove the ~ dep on flac 1.1.2


By doing so we'll be able to unmask flac 1.1.3 as soon as the deptree will be
correct.

------- Comment #1 From Alexis Ballier 2006-12-09 01:57:29 0000 -------
Created an attachment (id=103667) [details]
Patch from Josh Coalson

It's named 0.9.0 as it was done when 0.9.1 was not out, but it applies as well
to 0.9.1.

------- Comment #2 From Chris Gianelloni (RETIRED) 2006-12-12 14:41:09 0000 -------
Fixed in CVS... thanks for the patch...

First Last Prev Next    No search results available      Search page      Enter new bug