Bug 157125 – media-sound/easytag-1.99.12 patch for new FLAC API

• Status: RESOLVED WONTFIX
• Product: Gentoo Linux

[Description Maarten Maathuis 2006-12-04 11:39:58 UTC]

easytag and many other applications cannot deal with the new FLAC 8 API (hardmasked 1.1.3 version in portage). Besides my player (which is a svn ebuild, not in portage) this the other essential thing for me. I made a patch to allow it to compile. Try it with both flac 1.1.2 and 1.1.3 (i only tested 1.1.3).

I intend to send this upstream pretty soon, but i figure a release might take a while. So here is the patch. Basic tests (like tagging a few albums) suggests it works fine.

[Comment 1 Maarten Maathuis 2006-12-04 11:41:34 UTC]

Created attachment 103345 [details, diff]
easytag_flac8.diff

Also test if backwards compatability is ok. I didn't.

[Comment 2 Maarten Maathuis 2006-12-07 00:54:48 UTC]

Is there something wrong with this patch?

[Comment 3 Chris Gianelloni (RETIRED) 2006-12-08 13:54:12 UTC]

Has this patch been sent upstream?

[Comment 4 Maarten Maathuis 2006-12-08 14:16:57 UTC]

Yes, and i got a reply saying he got a patch from the main flac dev, but i haven't tried it yet. So put this on hold for the moment.

[Comment 5 Maarten Maathuis 2006-12-11 08:30:50 UTC]

Created attachment 103809 [details, diff]
patch_19912_use_flac_1.1.3.diff

Patch the easytag author got from the main flac author.

[Comment 6 Chris Gianelloni (RETIRED) 2006-12-12 06:34:01 UTC]

I'm marking this as WONTFIX since I'm about to close bug #157792 and it already has the patch included.