152096 – sys-power/cpufreqd-2.2.0: move /etc/cpufreqd.conf to /etc/conf.d/cpufreqd

Bug 152096 - sys-power/cpufreqd-2.2.0: move /etc/cpufreqd.conf to /etc/conf.d/cpufreqd

Summary: sys-power/cpufreqd-2.2.0: move /etc/cpufreqd.conf to /etc/conf.d/cpufreqd

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	New packages (show other bugs)
Hardware:	All Linux

Importance:	Normal enhancement (vote)
Assignee:	Christian Heim (RETIRED)

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2006-10-20 05:07 UTC by Daniel Franke
Modified:	2006-10-22 01:27 UTC (History)
CC List:	3 users (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Daniel Franke 2006-10-20 05:07:35 UTC

To increase consistency with other ebuilds, I think that "/etc/cpufreqd.conf" should be moved to "/etc/conf.d/cpufreqd" -- if possible.

Comment 1 Christian Heim (RETIRED) gentoo-dev

2006-10-20 12:25:57 UTC

(In reply to comment #0)
> To increase consistency with other ebuilds, I think that "/etc/cpufreqd.conf"
> should be moved to "/etc/conf.d/cpufreqd" -- if possible.

Problem is, that its a *package* related configure file not a gentoo init.d configure file. So it has no use for you in /etc/conf.d.

Comment 2 Christian Heim (RETIRED) gentoo-dev

2006-10-20 12:30:15 UTC

Guess I was a bit too fast (sorry).

Comment 3 Christian Heim (RETIRED) gentoo-dev

2006-10-20 12:52:11 UTC

(In reply to comment #0)
> To increase consistency with other ebuilds, I think that "/etc/cpufreqd.conf"
> should be moved to "/etc/conf.d/cpufreqd" -- if possible.

Its actually possible, fixed in CVS.

Comment 4 Michiel de Bruijne 2006-10-21 06:32:27 UTC

This change breaks cpufreqd, please revert/fix


# /etc/init.d/cpufreqd start
/etc/conf.d/cpufreqd: line 1: [General]: command not found
/etc/conf.d/cpufreqd: line 5: [/General]: No such file or directory
/etc/conf.d/cpufreqd: line 8: [Profile]: command not found
/etc/conf.d/cpufreqd: line 13: [/Profile]: No such file or directory
/etc/conf.d/cpufreqd: line 15: [Profile]: command not found
/etc/conf.d/cpufreqd: line 20: [/Profile]: No such file or directory
/etc/conf.d/cpufreqd: line 23: [Rule]: command not found
/etc/conf.d/cpufreqd: line 24: on: command not found
/etc/conf.d/cpufreqd: line 27: [/Rule]: No such file or directory
/etc/conf.d/cpufreqd: line 29: [Rule]: command not found
/etc/conf.d/cpufreqd: line 30: off: command not found
/etc/conf.d/cpufreqd: line 33: [/Rule]: No such file or directory
/etc/conf.d/cpufreqd: line 35: [Rule]: command not found
/etc/conf.d/cpufreqd: line 36: temperature: command not found
/etc/conf.d/cpufreqd: line 40: [/Rule]: No such file or directory

Comment 5 Alon Bar-Lev (RETIRED) gentoo-dev

2006-10-21 09:22:03 UTC

Hello Christian,

I reopen this bug since it does not work, you cannot put in /etc/conf.d files that are not bash style source. And cpufreqd.conf is not such.

You can, however put a file at /etc/conf.d that points to the right config:

/etc/conf.d/cpufreqd[.*]
CONFIGFILE=/etc/cpufreqd.conf

Regards,

Comment 6 Christian Heim (RETIRED) gentoo-dev

2006-10-22 01:27:33 UTC

(In reply to comment #4)
> This change breaks cpufreqd, please revert/fix

(In reply to comment #5)
> Hello Christian,
> 
> I reopen this bug since it does not work, you cannot put in /etc/conf.d files
> that are not bash style source. And cpufreqd.conf is not such.

Thank you both, Michiel and Alon. I just commited another rev-bump (I'm really sorry), which will hopefully fix these issues.