Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 139884 - libgphoto2 doesn't use USE_EXPAND
Summary: libgphoto2 doesn't use USE_EXPAND
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Other
: High minor (vote)
Assignee: Alastair Tse (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 157765
  Show dependency tree
 
Reported: 2006-07-10 07:29 UTC by John Herdy
Modified: 2007-01-27 20:09 UTC (History)
9 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
use_expand.patch (libgphoto2-iuse.patch,5.95 KB, patch)
2006-08-24 14:20 UTC, Simon Stelling (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description John Herdy 2006-07-10 07:29:20 UTC
when you start emerging libgphoto2 then you get a message:
 * All camera drivers will be built since you did not specify
 * via the CAMERAS variable what camera you use.
 * libgphoto2 supports: all adc65 agfa-cl20 aox barbie canon casio clicksmart310
        digigr8 digita dimera directory enigma13 fuji gsmart300 hp215 iclick jamcam jd11 kodak konica largan lg_gsm mars minolta mustek panasonic pccam300
        pccam600 polaroid ptp2 ricoh samsung sierra sipix smal sonix sonydscf1
        sonydscf55 soundvision spca50x sq905 stv0674 stv0680 sx330z template
        toshiba

libgphoto2 is almost always emerged as a dependency. most users don't see this message. a lot of ebuilds use use_expand for hardware related selection e.g INPUT_DEVICES or VIDEO_CARDS this way it is possible to track these possibilities upfront and avoid duplication with other camera related ebuilds.
Comment 1 Simon Stelling (RETIRED) gentoo-dev 2006-08-24 14:20:27 UTC
Created attachment 95035 [details, diff]
use_expand.patch

I would also like to see libgphoto2 to use USE_EXPAND. It makes the selection more visible, is the de-facto standard and ensures that it gets rebuilt when --newuse is used and something changed. Attached is a patch which does everything needed. Note that you will have to discuss the addition of CAMERAS to the list of USE_EXPAND variables on gentoo-dev before applying this patch. Also not that I did not test it yet, that's up to you ;)
Comment 2 Luca Marturana 2006-12-10 07:12:51 UTC
I tried the proposed patch on my system and all worked fine. I hope that this will be added in Portage.
Comment 3 Simon Stelling (RETIRED) gentoo-dev 2006-12-13 03:11:52 UTC
ping. Alastair, if you don't object within one week (or do it yourself of course), I will do this whenever I get to it.
Comment 4 Alon Bar-Lev (RETIRED) gentoo-dev 2007-01-19 19:21:45 UTC
Well... A week passed... :)

Simon... Please don't modify ebuild, refer to bug#157765.
And I think you have a missing space in USE_EXPAND.

Any time table?
Since Alastiar seems not responing at all!
Comment 5 Simon Stelling (RETIRED) gentoo-dev 2007-01-20 03:27:27 UTC
> Any time table?
> Since Alastiar seems not responing at all!

Yes. Personally I won't do this until I have access to my devbox again, which is in February. Feel free to do it, though.

OT for Alon: Did you see the mail I sent you?
Comment 6 Alon Bar-Lev (RETIRED) gentoo-dev 2007-01-27 16:27:22 UTC
No response from list, I guess nobody mind... :)
Comment 7 Michiel de Bruijne 2007-01-27 20:09:32 UTC
(In reply to comment #6)
> No response from list, I guess nobody mind... :)
> 

Thanks a lot Alon, it's really appreciated!