Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 134131 - openoffice-2.0.2-r1 doesn't use java eclasses
Summary: openoffice-2.0.2-r1 doesn't use java eclasses
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Java team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-05-23 10:13 UTC by Jan Callewaert
Modified: 2006-05-30 11:16 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
fixed ebuild using java-pkg eclass (openoffice-2.0.2-r1.ebuild,7.70 KB, text/plain)
2006-05-23 10:14 UTC, Jan Callewaert
Details
diff against the original ebuild (diff,244 bytes, patch)
2006-05-23 10:32 UTC, Jan Callewaert
Details | Diff
diff against the original ebuild openoffice-2.0.2-r1 (diff,890 bytes, patch)
2006-05-24 00:51 UTC, Jan Callewaert
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Callewaert 2006-05-23 10:13:03 UTC
Compiling openoffice-2.0.2-r1 fails when using the java migration overlay. The ebuild should inherit java-pkg and call java-pkg_pkg_setup in the function pkg-setup.
Comment 1 Jan Callewaert 2006-05-23 10:14:04 UTC
Created attachment 87332 [details]
fixed ebuild using java-pkg eclass

Fixed ebuild using java-pkg eclass. It's still compiling so I can't be sure, but it looks good.
Comment 2 Jakub Moc (RETIRED) gentoo-dev 2006-05-23 10:15:59 UTC
We don't support overlays... Also, please attach a unified diff instead of a huge ebuild.
Comment 3 William L. Thomson Jr. (RETIRED) gentoo-dev 2006-05-23 10:23:20 UTC
All that needs to happen is for someone to add java-pkg to the inherited eclasses at the top of the ebuild. The in pkg_setup add somewhere 
use java && java-pkg_pkg_setup

A patch can be made, but very minor changes.

One should not use JAVA_HOME without inheriting java-pkg, and calling java-pkg_pkg_setup.
Comment 4 Jan Callewaert 2006-05-23 10:32:49 UTC
Created attachment 87334 [details, diff]
diff against the original ebuild
Comment 5 Vlastimil Babka (Caster) (RETIRED) gentoo-dev 2006-05-23 14:51:04 UTC
My experience is that openoffice emerge fails with migration overlay if jdk 1.5 is set as generation-2 system vm, because the ebuild doesn't determine build vm and probably somewhere executes directly "javac" without explicit path to 1.4 jdk (although the ebuild says at some place that it's using 1.4 jdk path) and thus calls 1.5 javac because of 1.5 system vm. It doesn't fail with 1.4 system vm.
Comment 6 William L. Thomson Jr. (RETIRED) gentoo-dev 2006-05-23 14:55:41 UTC
Well if it was a proper generation 1 ebuild then that would not be the case. Thus it needs to inherit java-pkg, and call java-pkg_pkg_setup. Now once the java migraiton overlay has been merged with portage. In the upcomming weeks. Then all java related ebuilds will need to be updated to a generation 2 ebuild. Which basically is a difference of java-pkg-2 vs just java-pkg.

Since it is just calling ${JAVA_HOME} on a system using migration overlay, it will use what ever that is set to. Usually a generation 2 jvm/jdk, >= 1.5.
Comment 7 Paul de Vrieze (RETIRED) gentoo-dev 2006-05-23 23:36:35 UTC
Jan, This diff is not unified. As such it can't be used to patch the ebuild. I do agree though that the java eclasses will have to be used.
Comment 8 Jan Callewaert 2006-05-24 00:51:18 UTC
Created attachment 87364 [details, diff]
diff against the original ebuild openoffice-2.0.2-r1

sorry, I made a unified one. This is diffed against -r1, there is a -r2 in ~x86, if necessary I also want to create a diff for that.
Comment 9 Andreas Proschofsky (RETIRED) gentoo-dev 2006-05-30 11:16:33 UTC
I've fixed this now in -r2, thanks for reporting, closing