Bugzilla Bug 127734

New version of wxGTK.

Created an attachment (id=83223) [details]
wxGTK-2.6.3.ebuild

Ebuild based on wxGTK-2.6.2-r1 with changed version and all pateches removed.

it's safe to bump, just a bugfix version.

Could the patches send in for #109515 please be included in that ebuild? The
dependency on X is currently really making things difficult. Thanks a lot!

Created an attachment (id=83331) [details]
Ebuild w/o X11 dependency (unless USE="X")

I guess should look something like this. Basically just added the stuff from
http://bugs.gentoo.org/show_bug.cgi?id=109515 comment #10 to the ebuild from
#1.

The ebuild does not allow unicode support. Need to add $(use_enable unicode) in
the configure line.

(In reply to comment #2)
> it's safe to bump, just a bugfix version.

In theory. In practice it has a few behavourial changes which might affect some
less used wx applications. At least that has been a fear among certain other
distributions. Personally I don't expect problems.

(In reply to comment #5)
> The ebuild does not allow unicode support. Need to add $(use_enable unicode) in the configure line.

Seems to work fine here through the eclass' configure_build function. That is,
at least with the ebuild modifications of mine to 2.6.2-r1 that will shortly
follow.

yes it needs the file modification.

Created an attachment (id=84428) [details]
Ebuid for wxGTK-2.6.3.2

This ebuild does the following different when compared to 2.6.2-r1, together
with elaboration:

* Use wxPython sources instead of wxAll
  + Ability to get subreleases == fewer need to patch, upstream takes care
quickly
  + Same download with wxPython, distfiles shared
  + wxPython-src-2.6.3.2, instead of wxWidgets-2.6.3 gives us:
    * gcc-3.2 compilation fix
    * Fixed potential buffer overrun when pasting from the clipboard.
  - Slightly longer download if only wxGTK is installed (and no wxPython)
  * There is an agreement between one of the wxGTK developers (myself) and
wxPython
    author (Robin Dunn) to coordinate subreleases a bit, to push wxGTK patches
in
    prior to a wxPython subrelease, and therefore essentially make wxPython
subreleases
    good subreleases of wxGTK too - this has been long the case in practice,
simply
    the agreement to let the other know about when a release is planned is new,
    to be able to push in patches beforehand, which gentoo can then get from
    upstream tarball.

* append-flags -fno-strict-aliasing
  + This was intended to be added for 2.6.3 upstream after my own gcc4 work to
wxGTK,
    but for some reason doesn't appear in the release. Fixes warnings and
theoretical bugs

* ~arch for all arches to be sure with so many changes

* ebuild changed from #109515 comment #10 incorporated with changes
  + opengl USE flag wrapped inside X check as well - it is dependant on
wxUSE_GUI,
    as witnessed in build/bakefiles/config.bkl, therefore on X USE flag
  + Remove --with-png/jpeg/tiff instead of depending on X - wx configure has
them
    taken care of automatically: enabled by default; disabled with
--disable-gui
    which we pass in case of USE -X
  + Should close bug #109515
  * Comment #10 author is someone with a very close name to mine, not me
    (that is, credits for both, if applicable - also the guys whose work was
merged in #10 in that case)

* Adds a different einfo if USE flag setting already is -X

* Use different sentences in pkg_postinst, because wxBase is installed in any
case.
  Old wording could make one think that wxBase is only installed with USE=-X,
while
  in reality then simply other libs are not built - with USE=X wxBase is also
built
  (every other library built depends on it).

* Tested with the following USE flag settings:
  * x11-libs/wxGTK-2.6.3.2  USE="X debug gnome opengl sdl unicode -doc
-joystick -odbc"
  * x11-libs/wxGTK-2.6.3.2  USE="debug gnome opengl sdl unicode -X -doc
-joystick -odbc"
  * x11-libs/wxGTK-2.6.3.2  USE="debug doc gnome opengl sdl unicode -X
-joystick -odbc"
  - doc USE flag mostly useless still. See bug #123786

(In reply to comment #7)
> yes it needs the file modification.

Which modifications?

why 2.6.3.2? where the .2 come from?

it's wxpython and not wxGTK!
why merging here?

(In reply to comment #10)
> why 2.6.3.2? where the .2 come from?

It is a subrelease number, used upstream. wxPython releases usually bump it up,
but it applies to every port, including wxGTK.

> it's wxpython and not wxGTK!
> why merging here?

The wxpython tarball includes wxGTK sources, and that at the state of version
2.6.3.2.
wxPython directory inside the tarball simply isn't used with this ebuild.
However, the existance of it in the tarball will come handy if you are emerging
wxpython-2.6.3.2 (which doesn't have an ebuild YET), as it can re-use the
distfiles.

2.6.3.2 instead of 2.6.3 gives us (I didn't wait out for the cvs diff for the
earlier list, that only had the first two of this):
* gcc-3.2 and below compilation fix
* some further wxClipboard fixes (including a fix for a possible buffer
overrun)
* a EVT_CHAR fix (regarding case sensitivity of character)
* wxListCtrl patch for context menus in empty area and crash fixes
* a fix for wxSocket in wxBase (without it an amule daemon with no X USE flag
doesn't work very well, for example)
* Crash fix for wxJPEGHandler::{Load,Save}File if verbose argument is
non-defaul false
* report error for GIF images without CLEAR code in the stream instead of
crashing

The benefits seem pretty clear.

after that, how to say "no"!

i ack it.
waiting for mainteiners to bump wxGTK and wxpython so.

found a little bug in ebuild:

ebuild     U ] x11-libs/wxGTK-2.6.3.2 [2.6.3_rc1] USE="X gnome joystick odbc
opengl sdl unicode -debug -doc" 0 kB [1]

/var/tmp/portage/wxGTK-2.6.3.2/work/wxPython-src-2.6.3.2/configure
--prefix=/usr --host=i686-pc-linux-gnu --mandir=/usr/share/man
--infodir=/usr/share/info --datadir=/usr/share --sysconfdir=/etc
--localstatedir=/var/lib --disable-debugreport --with-zlib --disable-debug
--disable-debug_gdb --with-sdl --enable-joystick --enable-opengl --with-opengl
--with-gnomeprint --with-gtk=2 --with-odbc --build=i686-pc-linux-gnu

it lacks the unicode flag.

confirmed in the configure script:

checking for --enable-timer... yes
checking for --enable-unicode... no
checking for --enable-sound... yes
checking for --enable-mediactrl... no

please add that.

oops maybe i'm wrong...is that the first ansi compilation and unicode will be
done later?

Bumped, thanks to Mart Raudsepp