Bug 127258 – vprintk error with openvz-sources-022.072

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Jason Stubbs (RETIRED) 2006-03-22 19:30:21 UTC]

kernel/printk.c:557: error: conflicting types for 'vprintk'
include/linux/kernel.h:101: error: previous declaration of 'vprintk' was here

printk.c:int vprintk(const char *fmt, va_list args)
kernel.h:asmlinkage int vprintk(const char *fmt, va_list args) __attribute__ ((format (printf, 1, 0)));

Not sure if this is an upstream thing or what.. Not even sure exactly what the problem is. "asmlinkage" perhaps?

Also, there's a ">" that shouldn't be there in openvz-sources's metadata.xml:
<email>[e-mail]></email>

[Comment 1 Jason Stubbs (RETIRED) 2006-03-22 19:52:23 UTC]

Unpacking and patching a vanilla tarball with openvz's patch gives the same thing so it's an upstream bug. It seems that kernel/printk.c's vprintk should be defined with asmlinkage as well.

[Comment 2 Jason Stubbs (RETIRED) 2006-03-22 20:07:24 UTC]

Obligatory `emerge --info` ;)

Portage 2.1_pre6-r5 (default-linux/x86/2006.0, gcc-3.4.5, glibc-2.3.5-r2, 2.6.8-022stab072-smp i686)
=================================================================
System uname: 2.6.8-022stab072-smp i686 Intel(R) Xeon(TM) CPU 2.40GHz
Gentoo Base System version 1.6.14
dev-lang/python:     2.4.2
sys-apps/sandbox:    1.2.12
sys-devel/autoconf:  2.13, 2.59-r7
sys-devel/automake:  1.4_p6, 1.5, 1.6.3, 1.7.9-r1, 1.8.5-r3, 1.9.6-r1
sys-devel/binutils:  2.16.1
sys-devel/libtool:   1.5.22
virtual/os-headers:  2.6.11-r2
ACCEPT_KEYWORDS="x86"
AUTOCLEAN="yes"
CBUILD="i686-pc-linux-gnu"
CFLAGS="-O2 -march=pentium4 -pipe"
CHOST="i686-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/kde/2/share/config /usr/kde/3/share/config /usr/share/config /var/qmail/control"
CONFIG_PROTECT_MASK="/etc/gconf /etc/init.d /etc/terminfo /etc/env.d"
CXXFLAGS="-O2 -march=pentium4 -pipe"
DISTDIR="/usr/portage/distfiles"
FEATURES="autoconfig distlocks sandbox sfperms strict"
GENTOO_MIRRORS="http://gentoo.gg3.net/"
MAKEOPTS="-j5"
PKGDIR="/usr/portage/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
USE="x86 boundschecking bzip2 cgi cli expat fam fastcgi force-cgi-redirect gd-external gif jpeg mysql nolvmstatic nptl nptlonly pcntl pcre php png readline session ssl truetype unicode userlocales utf8 zlib elibc_glibc kernel_linux userland_GNU"
Unset:  ASFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, LANG, LC_ALL, LDFLAGS, LINGUAS, PORTDIR_OVERLAY

As you can see there adding asmlinkage worked.

[Comment 3 Christian Heim (RETIRED) 2006-04-04 03:37:42 UTC]

Jason, could you please test if the problem still presists with openvz-sources-022.072-r1 ?

[Comment 4 Kirill Korotaev 2006-04-04 04:52:43 UTC]

Haven't seen this before ... :/

commited patch diff-ext3-vprintk-warns-b to 022stab076 kernel.

[Comment 5 Kirill Korotaev 2006-04-04 04:53:21 UTC]

Created attachment 83875 [details, diff]
diff-ext3-vprintk-warns-b patch

[Comment 6 Kirill Korotaev 2006-04-04 04:54:01 UTC]

More info: specific to 2.6.8 only.

[Comment 7 Christian Heim (RETIRED) 2006-04-05 04:16:11 UTC]

Fixed in CVS, kudos to both of you!

[Comment 8 Jason Stubbs (RETIRED) 2006-04-05 06:43:13 UTC]

I haven't confirmed by way of the ebuild as I'm without a testing machine at the moment. But the patch is exactly what I changed locally to get it to compile myself and ran it for a day or two without any issue afterward.