Bug 121317 – helpers should do error checking

• Status: RESOLVED FIXED
• Product: Portage Development

[Description Simon Stelling (RETIRED) 2006-02-02 09:52:06 UTC]

currently, the do* scripts don't exit with a non-zero status when a critical command fails, except if it is the last one. However, they should rather abort than pretend everything works fine. At least dobin and dolib should do proper error checking so the ebuild can bail out if something breaks.

[Comment 1 Simon Stelling (RETIRED) 2006-02-02 09:52:35 UTC]

Created attachment 78734 [details, diff]
an attempt to fix the issue

[Comment 2 SpanKY 2006-02-02 19:04:11 UTC]

imo the scripts should exit non-zero, but install as many files/things as possible

[Comment 3 Simon Stelling (RETIRED) 2006-02-03 02:44:27 UTC]

Comment on attachment 78734 [details, diff]
an attempt to fix the issue

that's true, didn't think of that possibility.. i'll provide an updated patch

[Comment 4 Simon Stelling (RETIRED) 2006-02-03 03:52:33 UTC]

Created attachment 78796 [details, diff]
install as much as possible, then exit appropriately

here we go

[Comment 5 SpanKY 2006-02-03 21:33:26 UTC]

cleaned up:
dodir

doconfd
doenvd
donitd

newconfd
newenvd
newinitd

newbin
newdoc
newexe
newins
newlib.a
newlib.so
newman
newsbin

[Comment 6 SpanKY 2006-02-03 21:56:12 UTC]

cleaned up dobin / dosbin

[Comment 7 SpanKY 2006-02-13 16:25:38 UTC]

dolib is fixed now

[Comment 8 SpanKY 2006-02-22 21:13:55 UTC]

doman now updated

[Comment 9 Simon Stelling (RETIRED) 2006-11-17 00:53:38 UTC]

i think this is done