Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 120350 - ksensors: patch to show SCSI/SATA disks
Summary: ksensors: patch to show SCSI/SATA disks
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] KDE (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Gentoo KDE team
URL: https://sourceforge.net/tracker/?func...
Whiteboard:
Keywords:
: 171208 (view as bug list)
Depends on: 173821
Blocks:
  Show dependency tree
 
Reported: 2006-01-25 15:25 UTC by Michael Mauch
Modified: 2007-04-15 02:11 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch for ksensors-0.7.3.ebuild (ksensors.patch,295 bytes, patch)
2006-01-25 15:26 UTC, Michael Mauch
Details | Diff
files/ksensors-scsi-disks.patch (ksensors-scsi-disks.patch,729 bytes, patch)
2006-01-25 15:28 UTC, Michael Mauch
Details | Diff
prevent ksensors from calling hddtemp with multiple params (segfault-workaround.patch,1.78 KB, patch)
2006-05-31 06:54 UTC, frederic bonnaud
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Mauch 2006-01-25 15:25:39 UTC
With the new Linux kernel 2.6.15 it is possible to use hddtemp for SCSI
or SATA disks. These disks appear as /dev/sda, /dev/sdb and so on.

ksensors currently only looks for IDE devices in /proc/ide. With the
attached patch ksensors first tries to open the directory /sys/block,
which has hd* and sd* entries. If /sys/block is not there, /proc/ide is
used as usual.

I sent this patch over a week ago to the upstream author, but got no answer. The current ksensors is from August 2004, so maybe he is busy with other things.
Comment 1 Michael Mauch 2006-01-25 15:26:32 UTC
Created attachment 78116 [details, diff]
Patch for ksensors-0.7.3.ebuild
Comment 2 Michael Mauch 2006-01-25 15:28:18 UTC
Created attachment 78117 [details, diff]
files/ksensors-scsi-disks.patch
Comment 3 frederic bonnaud 2006-05-31 06:54:10 UTC
Created attachment 87980 [details, diff]
prevent ksensors from calling hddtemp with multiple params

on my box, hddtemp segfault when call with : 
hddtemp -q /dev/hdd /dev/hdc
but, not if called like :
hddtemp -q /dev/hdd
hddtemp -q /dev/hdc
so, ksensors need to be patch not to so. 
that's what the attached patch is doing
(it may be better to fix hddtemp but this dirty hack work for me)
Comment 4 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2006-09-12 15:43:31 UTC
Just ran into this bug while looking at SATA stuff.
Maybe take the patches to upstream?
Comment 5 Michael Mauch 2006-09-14 14:39:27 UTC
I sent the first patch to the address listed on ksensors.sf.net in January, but didn't get an answer until now. If you (or somebody else) knows how to contact upstream, you're welcome to forward these patches.
Comment 6 Charlie Shepherd (RETIRED) gentoo-dev 2006-11-25 07:12:00 UTC
The patches look good, unfortunately we don't normally accept patches that add features, as they aren't in keeping with our policy of 'Try to distribute as similar to upstream as possible'. The patches have been submitted upstream (see URL), and I've sent an email to the author.
Comment 7 Jakub Moc (RETIRED) gentoo-dev 2007-03-17 07:59:57 UTC
*** Bug 171208 has been marked as a duplicate of this bug. ***
Comment 8 Carsten Lohrke (RETIRED) gentoo-dev 2007-04-09 17:01:22 UTC
As this application is abandoned, resolution upstream is unreasonable. Using bug 173821 as tracker.
Comment 9 Wulf Krueger (RETIRED) gentoo-dev 2007-04-15 02:11:02 UTC
This has been fixed by using the Debian patchset from bug 171208. I've just committed ksensors-0.7.3-r1 to CVS.