Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 120042 - add language support to mozilla-thunderbird-bin
Summary: add language support to mozilla-thunderbird-bin
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Mozilla Gentoo Team
URL:
Whiteboard:
Keywords:
: 156005 (view as bug list)
Depends on:
Blocks:
 
Reported: 2006-01-23 04:50 UTC by Eero Volotinen
Modified: 2006-12-21 20:47 UTC (History)
14 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
modified-mozilla-thunderbird.ebuild-to-add-linguas (mozilla-thunderbird-1.5.ebuild,6.48 KB, text/plain)
2006-01-23 04:55 UTC, Eero Volotinen
Details
add language support to mozilla-thunderbird (mozilla-thunderbird-1.5-r1.ebuild,6.07 KB, text/plain)
2006-02-07 05:05 UTC, Jimmy.Jazz
Details
mozilla-thunderbird-1.5.0.4-r1.ebuild (mozilla-thunderbird-1.5.0.4-r1.ebuild,8.06 KB, text/plain)
2006-06-25 23:43 UTC, Tim Harder
Details
mozilla-thunderbird-bin-1.5.0.4.ebuild (mozilla-thunderbird-bin-1.5.0.4.ebuild,3.74 KB, text/plain)
2006-07-03 06:01 UTC, Davide Cendron (RETIRED)
Details
Ebuild with spell support (mozilla-thunderbird-1.5.0.7.ebuild,8.26 KB, text/plain)
2006-09-19 06:13 UTC, Maxxer
Details
Ebuild with spell support (mozilla-thunderbird-1.5.0.7.ebuild,8.49 KB, text/plain)
2006-09-20 06:32 UTC, Maxxer
Details
Ebuild with spell support (mozilla-thunderbird-1.5.0.7.ebuild,8.54 KB, text/plain)
2006-09-21 06:06 UTC, Maxxer
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Eero Volotinen 2006-01-23 04:50:14 UTC
Add language LINGUAS= support to mozilla-thunderbird ebuild.
This should be almost copy paste from mozilla-firefox.

Maybe I can submit patch after testing?
Comment 1 Eero Volotinen 2006-01-23 04:55:58 UTC
Created attachment 77899 [details]
modified-mozilla-thunderbird.ebuild-to-add-linguas
Comment 2 Eero Volotinen 2006-01-23 04:57:58 UTC
(In reply to comment #1)
> Created an attachment (id=77899) [edit]
> modified-mozilla-thunderbird.ebuild-to-add-linguas
> 

for testing / modification. should work?

Comment 3 mikael lammentausta 2006-01-23 07:54:26 UTC
LINGUAS flag should work for 1.5-r2 (-bin at least)
Comment 4 Eero Volotinen 2006-01-23 08:13:42 UTC
Well, I mean source based version.

Anyway my ebuild still not work correctly. But enable it on source version should be easy.
Comment 5 Jimmy.Jazz 2006-02-07 05:05:18 UTC
Created attachment 79109 [details]
add language support to mozilla-thunderbird

I suggest you another customized ebuild file. See the attachement file above.

Of course, i don't have too much experience about how to write an acceptable ebuild file but this one works pretty well for my own needs.
To make it work i had to use the wget command instead of the gentoo SRC_URI  variable. 
In fact, during the digest creation file, the ebuild command always downloads some "firefox" .xpi files from a gentoo mirror instead of the mozilla ftp url i have specified.

The initial syntax was:

SRC_URI="${SRC_URI} linguas_${lang}?  http://ftp.mozilla.org/pub/mozilla.org/thunderbird/releases/${PV}/linux-i686/xpi/${lang}.xpi)"

The following method works better,
wget http://ftp.mozilla.org/pub/mozilla.org/thunderbird/releases/${PV}/linux-i686/xpi/${xpiname}
Comment 6 Jory A. Pratt 2006-02-07 05:42:42 UTC
Will happen in 1.5.0.1 when it is released. Will use same exact setup as firefox for the most part.
Comment 7 Rob K 2006-03-24 04:38:58 UTC
I know this is not quite related but, can you add LC_ALL to the thunderbird launcher, or at least allow this to be found in the environment.  Without this the date format defaults to en_US (eg mm/dd/yyyy)

eg export LC_ALL="en_GB.UTF-8"
Comment 8 Fab 2006-04-05 06:20:41 UTC
(In reply to comment #6)
> Will happen in 1.5.0.1 when it is released. Will use same exact setup as
> firefox for the most part.
> 

If you add LINGUAS support in next release, please add also dictionaries :
http://dictionaries.mozdev.org/installation.html

.aff and .dic files must be copied in /usr/lib/mozilla-thunderbird/components/myspell

Thanks.
Comment 9 Wolfram Schlich (RETIRED) gentoo-dev 2006-06-04 04:56:21 UTC
Now it's 1.5.0.4 -- still no LINGUAS support in the regular source-based ebuild :-(
Comment 10 Jory A. Pratt 2006-06-04 05:19:16 UTC
(In reply to comment #9)
> Now it's 1.5.0.4 -- still no LINGUAS support in the regular source-based ebuild
> :-(
> 

As the only active dev for mozilla herd, I am only concerned with getting threw security fixes with mozilla products. If at some point security issues die down I will get linguas support added to both source and binary build.
Comment 11 Tim Harder gentoo-dev 2006-06-25 23:40:21 UTC
I am having a few problems adapting the techniques used in the firefox ebuilds to add LINGUAS and dictionary support to thunderbird. 

First off, when trying to digest the ebuild, it will start downloading all the xpi packages for languages not set in LINGUAS. This is probably due to my poor understanding of linguas handling in ebuilds. If anyone could point out some documentation or helpful tips that would be most appreciated. I saw that others have called wget inline to retreive packages, but I don't think that method should be used for offical ebuilds.

In addition, dictionaries do not download properly yet. I can only get the en-US to download even after adding more languages to my LINGUAS.

It will probably be a good idea to push the needed xpi packages onto gentoo mirrors with better names like thunderbird-<lang>-${PV}.xpi and thunderbird-spell-<lang>-${PV}.xpi when these changes are finally rolled into the official tree, but that will probably be some time from now seeing as though Gentoo's only Mozilla Herd member has resigned.

Finally, does anyone know what the LANGS and SHORTLANGS handling does in the ebuild? What exactly is SHORTLANGS needed for? SHORTLANGS appears to be a subset of LANGS in the firefox ebuild which I sort of emulated.
Comment 12 Tim Harder gentoo-dev 2006-06-25 23:43:30 UTC
Created attachment 90167 [details]
mozilla-thunderbird-1.5.0.4-r1.ebuild

This is the currently broken ebuild I am experimenting with that relates to the post above.
Comment 13 Davide Cendron (RETIRED) gentoo-dev 2006-07-03 06:01:53 UTC
Created attachment 90767 [details]
mozilla-thunderbird-bin-1.5.0.4.ebuild

I submit a modified ebuild for mozilla-thunderbird-bin with LINGUAS support. Feel free to test it :)
Comment 14 Jory A. Pratt 2006-07-03 12:07:59 UTC
ebuild could never be added to gentoo as they do not use versioning support upstream I will handle this later when we finish seamonkey business.
Comment 15 Olliver Schinagl 2006-08-23 06:36:21 UTC
Ok i bumped the version to 1.5.0.5-r1 and removed ro and en_US from LANGS (couldn't dl the files)

I got it to build now, let's see if I get it to install in my language.

Which brings me to the following question, in OOo I noticed you can have several languages in your LINGUAS and choose them from the UI within OOo.

Is this actually possible with thunderbird (firefox) aswell? (Either based on the LC_ALL or other variable?
Comment 16 Olliver Schinagl 2006-08-23 08:44:06 UTC
ok after a little while of compiling, it starts puking these out:

gmake[3]: Entering directory `/opt/tmp/portage/mozilla-thunderbird-1.5.0.5-r1/work/mozilla/security/coreconf'
syntax error at -e line 3, near "while"
syntax error at -e line 7, near "}"
Execution of -e aborted due to compilation errors.
cd nsinstall; /usr/bin/gmake -j1 export
gmake[4]: Entering directory `/opt/tmp/portage/mozilla-thunderbird-1.5.0.5-r1/work/mozilla/security/coreconf/nsinstall'
syntax error at -e line 3, near "while"
syntax error at -e line 7, near "}"


which goes on for a few 500 lines and ends a few of these:

1/work/mozilla/dist/include/nspr -I/opt/tmp/portage/mozilla-thunderbird-1.5.0.5-r1/work/mozilla/dist/include/dbm -I../../../../dist/public/dbm  quickder.c
In file included from quickder.c:43:
secasn1.h:48:21: plarena.h: No such file or directory
In file included from secasn1.h:50,
                 from quickder.c:43:
seccomon.h:50:21: prtypes.h: No such file or directory
In file included from seccomon.h:61,
                 from secasn1.h:50,
                 from quickder.c:43:


I did notice that it tried fetching a 1.5.0.4 patch, so maybe just a version bump isn't the best thing ...

Anyway, hopefully we'll get a somewhat working ebuild out there soon, I really do need localized version for my mother/sister : )
Comment 17 Stuart Longland (RETIRED) gentoo-dev 2006-09-16 18:29:25 UTC
Hi,
  I didn't see this bug when I committed mozilla-thunderbird-1.5.0.7... however, I did put in LINGUAS support.  It's pretty much a copy&paste from the Firefox ebuilds.

  Those looking for a localised Thunderbird, please give the lastest release a try and report back.  This will likely get bumped to stable shortly, as there are some security fixes in this latest release.

Regards,
Stuart Longland
Comment 18 Eero Volotinen 2006-09-17 03:21:58 UTC
Not working. 

LINGUAS="fi" and emerge mozilla-thunderbird-1.5.0.7 ..

>> Source compiled.
>>> Test phase [not enabled]: mail-client/mozilla-thunderbird-1.5.0.7

>>> Install mozilla-thunderbird-1.5.0.7 into /var/tmp/portage/mozilla-thunderbir                                                                             d-1.5.0.7/image/ category mail-client
/usr/portage/mail-client/mozilla-thunderbird/mozilla-thunderbird-1.5.0.7.ebuild:                                                                              line 180: xpi_install: command not found
 * Setting default locale to fi ...
sed: can't read /var/tmp/portage/mozilla-thunderbird-1.5.0.7/image//usr/lib/mozi                                                                             lla-thunderbird/defaults/pref/thunderbird.js: No such file or directory
sed: can't read /var/tmp/portage/mozilla-thunderbird-1.5.0.7/image//usr/lib/mozi                                                                             lla-thunderbird/defaults/pref/thunderbird-l10n.js: No such file or directory                                                                                                                                                                                                                                                        [ !! ]
!!! ERROR: mail-client/mozilla-thunderbird-1.5.0.7 failed.
Call stack:
  ebuild.sh, line 1546:   Called dyn_install
  ebuild.sh, line 1020:   Called src_install
  mozilla-thunderbird-1.5.0.7.ebuild, line 189:   Called die

!!! sed failed to change locale
!!! If you need support, post the topmost build error, and the call stack if rel                                                                             evant.
Comment 19 Eero Volotinen 2006-09-17 03:44:21 UTC
I think there is wrong filename in ebuild for preference file

they should be all-thunderbird.js and all-l10n.js ?

Just testing. compiling takes some time.
Comment 20 Eero Volotinen 2006-09-17 07:37:28 UTC
It is not in correct place?
Comment 21 Alexander M. Turek 2006-09-17 07:41:16 UTC
(In reply to comment #20)
> It is not in correct place?
> 

See bug #147829
Comment 22 Maxxer 2006-09-19 06:13:45 UTC
Created attachment 97401 [details]
Ebuild with spell support

This is a preliminary ebuild with patch from #147829 which also enables spell support.

NEEDS TESTING, as where I am now I can't download all the dictionaries to create the manifest. :(
Also the auto selection of dictionary is missing.

Please let me know if it works!
Comment 23 Maxxer 2006-09-20 06:32:25 UTC
Created attachment 97541 [details]
Ebuild with spell support

I've updated a little the ebuild. 
But it doesn't work anyway!
xpi_install complains about missing install.rdf in the spell-it.xpi I'm using.
In fact the file is missing, but exists an install.js.
I don't know if portage's mozilla eclass supports this method.
Comment 24 Maxxer 2006-09-21 06:06:13 UTC
Created attachment 97634 [details]
Ebuild with spell support

Finally this version works! :)

But there are still some bugs:
1. the dictionary isn't auto-selected, you have to choose it when you open TB
2. there are some troubles with en linguas, as it downloads en-NZ and so on dict  files
Comment 25 Daniel Pielmeier gentoo-dev 2006-09-23 05:03:51 UTC
(In reply to comment #24)
> Created an attachment (id=97634) [edit]
> Ebuild with spell support
> 
> Finally this version works! :)
> 

Hi i am testing your ebuild with spell support, but it doesn't work for me.

My settings are:

[ebuild   R   ] mail-client/mozilla-thunderbird-1.5.0.7  USE="crypt gnome ipv6 ldap spell -debug -xinerama -xprint" LINGUAS="de -bg -ca -cs -da -el -en_GB -es -es_AR -es_ES -eu -fi -fr -ga -ga_IE -gu_IN -he -hu -it -ja -ko -lt -mk -nb -nb_NO -nl -pa_IN -pl -pt_BR -ru -sk -sl -sv -sv_SE -tr -zh_CN" 0 kB [1]

When everything gets unpacked i get the ewarn message:

* Sorry, but mozilla-thunderbird does not support the de SPELL

How do i enable the SPELL_LANGS mentioned in the ebuld? Should they show up in /etc/make.conf. I have tested:

without SPELL_LANGS in make.conf
with SPELL_LANGS="de-DE"
and with SPELL_LANGS="de_DE"

In every case i get the ewarn message.

If you need more information feel free to ask!


Another question is that eyery spell and lang files are downloaded by the ebuild regardless of the language and spell settings. Is this normal?

Thanks Daniel
Comment 26 Maxxer 2006-09-25 00:59:10 UTC
(In reply to comment #25)

> When everything gets unpacked i get the ewarn message:
> 
> * Sorry, but mozilla-thunderbird does not support the de SPELL

I'll have a look when I can access my pc.

> How do i enable the SPELL_LANGS mentioned in the ebuld? Should they show up in
> /etc/make.conf. 

No. The spell language is auto detected from the LINGUAS variable.
But maybe it can be more interesting something as you "suggest", because I may wish to have spell in 5 languages.

> Another question is that eyery spell and lang files are downloaded by the
> ebuild regardless of the language and spell settings. Is this normal?

No, it's not normal. There must be a problem with the loop getting the url.

Thanks for your feedback, I'll dig the problems asap.
maxxer
Comment 27 Jakub Moc (RETIRED) gentoo-dev 2006-11-23 01:22:07 UTC
*** Bug 156005 has been marked as a duplicate of this bug. ***
Comment 28 Christian Marie (RETIRED) gentoo-dev 2006-12-21 20:47:38 UTC
Closing via Anarchy: "fixed in 1.5.0.9"