First Last Prev Next    No search results available      Search page      Enter new bug
Bug#: 119538
Alias:
Product:
Component:
Status: RESOLVED
Resolution: FIXED
Assigned To: x86-kernel@gentoo.org (DEPRECATED) <x86-kernel@gentoo.org>
Hardware:
OS:
Version:
Priority:
Severity:
Reporter: Patrizio Bassi <hetfield666@gmail.com>
Add CC:
CC:
URL:
Summary:
Status Whiteboard:
Keywords:

Filename Description Type Creator Created Size Actions
patch-2.6.16-rc1 Submount compile fix patch Patrizio Bassi 2006-01-19 05:32 0000 633 bytes Details | Diff
submount-2.6.16-fix.diff patch to fix 2.6.16 patch Patrizio Bassi 2006-03-22 01:55 0000 1.09 KB Details | Diff
Create a New Attachment (proposed patch, testcase, etc.) View All

Bug 119538 depends on: Show dependency tree
Bug 119538 blocks: 126972
Votes: 0    Show votes for this bug    Vote for this bug

Additional Comments: (this is where you put emerge --info)


Not eligible to see or edit group visibility for this bug.






View Bug Activity   |   Format For Printing   |   XML   |   Clone This Bug


Description:   Opened: 2006-01-19 05:31 0000
due to new mutex system submount compiles not more.

here is my fix, tested and working:

--- a/subfs-0.9/subfs.c 2004-02-26 23:54:58.000000000 +0100
+++ b/subfs-0.9/subfs.c 2006-01-19 14:12:26.000000000 +0100
@@ -221,14 +221,14 @@
        struct vfsmount *child;

        /* This is ugly, but prevents a lockup during mount. */
-       up(&dir->i_sem);
+       mutex_lock(&dir->i_mutex);
        if (down_interruptible(&sfs_mnt->sem)) {
-               down(&dir->i_sem);/*put the dir sem back down if interrupted*/
+               mutex_unlock(&dir->i_mutex);
                return ERR_PTR(-ERESTARTSYS);
        }
        child = get_child_mount(sfs_mnt);
        up(&sfs_mnt->sem);
-       down(&dir->i_sem);
+       mutex_unlock(&dir->i_mutex);
        if (IS_ERR(child))
                return (void *) child;
        subfs_send_signal();

please apply.
full story link here:
http://www.patriziobassi.it/blog/?p=8

------- Comment #1 From Patrizio Bassi 2006-01-19 05:32:05 0000 -------
Created an attachment (id=77525) [details]
Submount compile fix

and file attachment too.

------- Comment #2 From Patrizio Bassi 2006-03-20 08:52:21 0000 -------
big warning

compilation works, but there are some deadlock that take process (like a file
manager or simple ls) to D status.

i've no idea how to solve those, keeping the mutexes.

------- Comment #3 From Patrizio Bassi 2006-03-22 01:54:22 0000 -------
fixed!

the problem was in a typo in the patch which changed lock/unlock sequence.

now works.

i've edited the patch so you can apply without any kernel version tests, done
in the patch.

please apply to portage and mark as fixed

------- Comment #4 From Patrizio Bassi 2006-03-22 01:55:14 0000 -------
Created an attachment (id=82851) [details]
patch to fix 2.6.16

full story and download link here:
http://www.patriziobassi.it/blog/?p=24

------- Comment #5 From Daniel Drake 2006-03-25 05:45:48 0000 -------
fixed and sent upstream, thanks!

First Last Prev Next    No search results available      Search page      Enter new bug