Bug 112980 – ebuilds for xine-lib do not support building a debug build

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Maximilian Schwerin 2005-11-19 03:21:55 UTC]

Debug builds of xine-lib are created by running make debug and make
install-debug.  It would be pretty easy to support this. I'll attach a patch
that uses the debug use flag to decide how to make.

Reproducible: Always
Steps to Reproduce:
1.
2.
3.

[Comment 1 Maximilian Schwerin 2005-11-19 03:22:39 UTC]

Created attachment 73172 [details, diff]
patch for xine-lib-1.0.1-r4.ebuild

[Comment 2 Maximilian Schwerin 2005-11-19 04:13:50 UTC]

Created attachment 73175 [details, diff]
patch (v2) for xine-lib-1.0.1-r4.ebuild

Sorry, I was a bit quick sending the first patch.

[Comment 3 Diego Elio Pettenò (RETIRED) 2005-11-19 07:54:18 UTC]

Are you sure it really does something? I think the only thing it could do is  
to add -g flags to CFLAGS/CXXFLAGS, but that's something you can do without  
having to change the ebuild on the user side...  
  

[Comment 4 Maximilian Schwerin 2005-11-20 01:53:10 UTC]

Running make debug substitutes DEBUG_CFLAGS for CFLAGS. DEBUG_CFLAGS are defined
as "-g -DDEBUG $CFLAGS" so it would be enough to add "-g -DDEBUG". But as far as
I understood this, the idea of having a debug useflag is to allow just what I
attached in my patch. Correct me if I'm wrong.

[Comment 5 Diego Elio Pettenò (RETIRED) 2005-11-20 04:33:30 UTC]

Well debug useflag is somewhat a bit uncertain about the use. I'll consider 
about adding a debug useflag to add -DDEBUG, I don't consider debug things for 
-g flag. 
 
But for sure I won't use a two-ways make/make install calls for that :) 

[Comment 6 Maximilian Schwerin 2005-11-20 05:05:44 UTC]

I don't really care how it is implemented. The only thing I'm interested in, is
having an easy way to build a debug version of this library.

[Comment 7 Diego Elio Pettenò (RETIRED) 2005-11-21 04:50:23 UTC]

Fixed and documented in xine maintainer guide.