Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 111626 - -fomit-frame-pointer makes mldonkey misbehave
Summary: -fomit-frame-pointer makes mldonkey misbehave
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High minor (vote)
Assignee: Gentoo net-p2p team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-11-05 12:06 UTC by Zeev Tarantov
Modified: 2005-11-20 16:55 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Zeev Tarantov 2005-11-05 12:06:46 UTC
I have run into strange behavior (100% cpu usage) that went away when filtering
out the CFLAGS

Reproducible: Always
Steps to Reproduce:
1. emerge net-p2p/mldonkey-2.6.7 while having "-fomit-frame-pointer" in your CFLAGS
2. /etc/init/mldonkey start

Actual Results:  
eats all idle cpu time

Expected Results:  
shouldn't

I don't know how to do ebuilds, so no patch here. but I figure there must be
some easy way to filter out unwanted cflags from /etc/make.conf on a per-package
basis. can anyone please do so for the ebuild?
Comment 1 Karol Wojtaszek (RETIRED) gentoo-dev 2005-11-06 07:32:36 UTC
Could you provide your emerge info?
Comment 2 spiralvoice 2005-11-07 14:39:30 UTC
Its a known bug, Cryptopp C++ code does not like this flag.
Current CVS already tries to filter it out by itself:

2005/11/05
4589: CryptoPP doesn't like -fomit-frame-pointer, so remove it (przemoc)

Please test, until 2.7.0 is released its advised to update to ebuild so
Gentoo users avoid the problem.
Comment 3 Zeev Tarantov 2005-11-08 09:17:21 UTC
http://savannah.nongnu.org/patch/?func=detailitem&item_id=4589#attached
Do we wait for upstream to release a version containing this patch?
Comment 4 spiralvoice 2005-11-08 10:01:20 UTC
(In reply to comment #3)
> http://savannah.nongnu.org/patch/?func=detailitem&item_id=4589#attached
> Do we wait for upstream to release a version containing this patch?

I would like to hear if this patch/or not using that CFLAG solves the problem
before releasing a new version. 2.7.0 should work without problems on Gentoo.
A user on the german forum already reported success.
Comment 5 spiralvoice 2005-11-10 01:06:55 UTC
Filtering CFLAGS should take place in MLDonkey ebuild, notes from Ocaml ebuild:

 * Building ocaml with unsafe CFLAGS can have unexpected results
 * Please retry building with safer CFLAGS before reporting bugs
 * Likewise, building with a hardened gcc is not possible.

Also hardened GCC should be handled by the ebuild.

MLdonkey 2.7.0 needs lablgtk-2.6.0 (not in portage, see bug #107501),
because of this patch:

2005/10/31
4583: GTK2 mlgui improvement (su_blanc)
Lablgtk-2.6.0 is needed for GTK2 mlgui, it fixes a mem leak with GdkPixbuf.
Comment 6 Zeev Tarantov 2005-11-10 10:07:54 UTC
RE #4: not using that cflag solves the problem for me. I have not tried the
patch, but it looks like it should do the same trick.
Comment 7 spiralvoice 2005-11-16 02:38:43 UTC
MLDonkey compiled with -fomit-frame-pointer also creates a wrong
EDK_client_private_key:

client_private_key = "/root/.mldonkey"

in my example. Normally it should start with "MIIBC", over 350 chars in total.
I will add a check in MLDonkey to change the key if it is wrong.
Comment 8 spiralvoice 2005-11-16 04:29:19 UTC
Please check this patch:
https://savannah.nongnu.org/patch/index.php?func=detailitem&item_id=4631
Comment 9 spiralvoice 2005-11-19 08:06:35 UTC
MLDonkey 2.7.0 has been released
Comment 10 Marcin Kryczek (RETIRED) gentoo-dev 2005-11-20 16:55:34 UTC
i've added filtering -fomit-frame-pointer in 2.6.7. sorry it took so long, but i'm kind of away all the time;/ 
i'll try to test and submit into cvs 2.7.0 tommorow, but i can't promise i'll be able to do it