Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 109671 - app-admin/sysklogd version upgrade, bug fixes, security fixes, feature enhancement
Summary: app-admin/sysklogd version upgrade, bug fixes, security fixes, feature enhanc...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-10-17 23:44 UTC by Cory Visi (RETIRED)
Modified: 2006-06-01 16:05 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
sysklogd-1.4.1-cvs-20051017.patch (sysklogd-1.4.1-cvs-20051017.patch,29.01 KB, patch)
2005-10-17 23:45 UTC, Cory Visi (RETIRED)
Details | Diff
sysklogd-1.4.1-caen-owl-syslogd-bind.diff (sysklogd-1.4.1-caen-owl-syslogd-bind.diff,3.14 KB, patch)
2005-10-17 23:46 UTC, Cory Visi (RETIRED)
Details | Diff
sysklogd-1.4.1-caen-owl-syslogd-drop-root.diff (sysklogd-1.4.1-caen-owl-syslogd-drop-root.diff,2.84 KB, patch)
2005-10-17 23:47 UTC, Cory Visi (RETIRED)
Details | Diff
sysklogd-1.4.1-caen-owl-klogd-drop-root.diff (sysklogd-1.4.1-caen-owl-klogd-drop-root.diff,4.22 KB, patch)
2005-10-17 23:47 UTC, Cory Visi (RETIRED)
Details | Diff
sysklogd-1.4.1-querymod.patch (sysklogd-1.4.1-querymod.patch,10.20 KB, patch)
2005-10-17 23:48 UTC, Cory Visi (RETIRED)
Details | Diff
sysklogd-1.4.1-querymod.patch (sysklogd-1.4.1-r11.ebuild.diff,1.53 KB, patch)
2005-10-17 23:51 UTC, Cory Visi (RETIRED)
Details | Diff
sysklogd-1.4.1-r11.ebuild.diff (sysklogd-1.4.1-r11.ebuild.diff,1.53 KB, patch)
2005-10-17 23:55 UTC, Cory Visi (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Cory Visi (RETIRED) gentoo-dev 2005-10-17 23:44:01 UTC
The sysklogd package, unfortunately, does not have a lot of development activity.  There has 
not been a new version released since 2001-03-11 (wow).  The development team has been 
making changes (very minimal) to the CVS tree, and seems to be content with distribution 
maintainers managing the patches themselves.

On that note, I think it's time Gentoo ramped up its version to get the latest code.  Here's what I 
did:
- Made a diff off of sysklogd CVS getting us to version 1.4.2 affectively.
- Removed mips patch (it's in the official tree now.)
- Converted 2.6-headers patch to querymod patch, it's real name, and stripped it down to the 
necessities.
- Added 3 security patches from CAEN/OWL.
- Made everything place nicely together.

This takes care of a whole bunch of minor security fixes to 1.4.1 and a lot of header fixes.  We 
still need the SO_BSDCOMPAT patch, unfortunately.  I am hoping that this also solves the 
ppc64 issues described in Bug 88099.  I don't have ppc64 to test on, so I am CC'ing the people 
involved in that bug so they can try this.

Enclosed are the new patch files and a patch against the latest ebuild.

If this is well-received, I'll update the init scripts to support the drop priv and bind address 
patches from CAEN/OWL.

There's quite a few fixes in 1.4.2, so I'll include the list here (from CVS/CHANGES):

 . Dmitry V. Levin <ldv@altlinux.org>
   - Close file descriptor in FindSymbolFile() in ksym.c in order not to
     leak file descriptors.
 . Solar Designer <solar@openwall.com>
   - improve crunch_list()
   - Prevent potential buffer overflow in reading messages from the
     kernel log ringbuffer.
   - Ensure that "len" is not placed in a register, and that the
     endtty() signal handler is not installed too early which could
     cause a segmentation fault or worse.
 . Steve Grubb <linux_4ever@yahoo.com>
   - fix memory calculation in crunch_list()
 . Martin Schulze <joey@infodrom.org>
   - klogd will reconnect to the logger (mostly syslogd) after it went
     away
   - On heavily loaded system syslog will not spit out error messages
     anymore when recvfrom() results in EAGAIN
   - Makefile improvements
   - Local copy of module.h
   - Improved sysklogd.8
   - Always log with syslogd's timezone and locale
   - Remove trailing newline when forwarding messages
 . Jon Burgess <Jon_Burgess@eur.3com.com>
   - Moved the installation of the signal handler up a little bit so it
     guaranteed to be available when the child is forked, hence, fixing a
     race condition.  This used to create problems with UML and fast
     machines.
 . Greg Trounson <gregt@maths.otago.ac.nz>
   - Improved README.linux
 . Ulf H
Comment 1 Cory Visi (RETIRED) gentoo-dev 2005-10-17 23:44:01 UTC
The sysklogd package, unfortunately, does not have a lot of development activity.  There has 
not been a new version released since 2001-03-11 (wow).  The development team has been 
making changes (very minimal) to the CVS tree, and seems to be content with distribution 
maintainers managing the patches themselves.

On that note, I think it's time Gentoo ramped up its version to get the latest code.  Here's what I 
did:
- Made a diff off of sysklogd CVS getting us to version 1.4.2 affectively.
- Removed mips patch (it's in the official tree now.)
- Converted 2.6-headers patch to querymod patch, it's real name, and stripped it down to the 
necessities.
- Added 3 security patches from CAEN/OWL.
- Made everything place nicely together.

This takes care of a whole bunch of minor security fixes to 1.4.1 and a lot of header fixes.  We 
still need the SO_BSDCOMPAT patch, unfortunately.  I am hoping that this also solves the 
ppc64 issues described in Bug 88099.  I don't have ppc64 to test on, so I am CC'ing the people 
involved in that bug so they can try this.

Enclosed are the new patch files and a patch against the latest ebuild.

If this is well-received, I'll update the init scripts to support the drop priv and bind address 
patches from CAEN/OWL.

There's quite a few fixes in 1.4.2, so I'll include the list here (from CVS/CHANGES):

 . Dmitry V. Levin <ldv@altlinux.org>
   - Close file descriptor in FindSymbolFile() in ksym.c in order not to
     leak file descriptors.
 . Solar Designer <solar@openwall.com>
   - improve crunch_list()
   - Prevent potential buffer overflow in reading messages from the
     kernel log ringbuffer.
   - Ensure that "len" is not placed in a register, and that the
     endtty() signal handler is not installed too early which could
     cause a segmentation fault or worse.
 . Steve Grubb <linux_4ever@yahoo.com>
   - fix memory calculation in crunch_list()
 . Martin Schulze <joey@infodrom.org>
   - klogd will reconnect to the logger (mostly syslogd) after it went
     away
   - On heavily loaded system syslog will not spit out error messages
     anymore when recvfrom() results in EAGAIN
   - Makefile improvements
   - Local copy of module.h
   - Improved sysklogd.8
   - Always log with syslogd's timezone and locale
   - Remove trailing newline when forwarding messages
 . Jon Burgess <Jon_Burgess@eur.3com.com>
   - Moved the installation of the signal handler up a little bit so it
     guaranteed to be available when the child is forked, hence, fixing a
     race condition.  This used to create problems with UML and fast
     machines.
 . Greg Trounson <gregt@maths.otago.ac.nz>
   - Improved README.linux
 . Ulf Härnhammar <Ulf.Harnhammar.9485@student.uu.se>
   - Bondary check for fscanf() in InitKsyms() and CheckMapVersion()
 . Colin Phipps <cph@cph.demon.co.uk>
   - Don't block on the network socket in case of package los
 . Dirk Mueller <mueller@kde.org>
   - Don't crash when filesize limit is reached (e.g. without LFS)
Comment 2 Cory Visi (RETIRED) gentoo-dev 2005-10-17 23:45:54 UTC
Created attachment 70905 [details, diff]
sysklogd-1.4.1-cvs-20051017.patch
Comment 3 Cory Visi (RETIRED) gentoo-dev 2005-10-17 23:46:37 UTC
Created attachment 70906 [details, diff]
sysklogd-1.4.1-caen-owl-syslogd-bind.diff
Comment 4 Cory Visi (RETIRED) gentoo-dev 2005-10-17 23:47:05 UTC
Created attachment 70907 [details, diff]
sysklogd-1.4.1-caen-owl-syslogd-drop-root.diff
Comment 5 Cory Visi (RETIRED) gentoo-dev 2005-10-17 23:47:31 UTC
Created attachment 70908 [details, diff]
sysklogd-1.4.1-caen-owl-klogd-drop-root.diff
Comment 6 Cory Visi (RETIRED) gentoo-dev 2005-10-17 23:48:04 UTC
Created attachment 70909 [details, diff]
sysklogd-1.4.1-querymod.patch
Comment 7 Cory Visi (RETIRED) gentoo-dev 2005-10-17 23:51:51 UTC
Created attachment 70910 [details, diff]
sysklogd-1.4.1-querymod.patch
Comment 8 Cory Visi (RETIRED) gentoo-dev 2005-10-17 23:55:43 UTC
Created attachment 70912 [details, diff]
sysklogd-1.4.1-r11.ebuild.diff

Attachment had the wrong name.
Comment 9 Eike Hein 2005-12-04 08:27:51 UTC
This updated ebuild solved a build error with linux-headers2.6.11-r2 during my
GCC 3.3 -> GCC 3.4 migration for me. 

It should be added to the tree. 
Comment 10 Cory Visi (RETIRED) gentoo-dev 2006-05-24 17:52:32 UTC
Ok, I finally decided to just go an add the new ebuild and patches to CVS.  Please provide feedback.
Comment 11 Cory Visi (RETIRED) gentoo-dev 2006-06-01 16:05:17 UTC
No complaints, bug is closed.