Bug 107924 – sci-libs/libgeda-20050313 needs patch to compile w/ gcc 4.*

• Status: RESOLVED DUPLICATE of bug 107929
• Product: Gentoo Linux

[Description Gustavo Ribeiro Alves 2005-10-02 13:12:30 UTC]

libgeda needs a patch to compile on gcc-4.*. The patch has already been
submitted upstream by the debian team, but an upstream version was not yet been
released.

The patch itself is trivial:

diff -urN ../tmp-orig/libgeda-20050313/include/globals.h ./include/globals.h
--- ../tmp-orig/libgeda-20050313/include/globals.h	2004-01-12 04:15:36.000000000
+0100
+++ ./include/globals.h	2005-03-18 15:44:34.527922372 +0100
@@ -49,7 +49,6 @@
 extern char rc_filename[256]; /* size is hack */
 #endif
 
-extern int logfile_fd;
 extern int do_logging;
 extern int logging_dest;

Please see http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=300256 for more
information.



Reproducible: Always
Steps to Reproduce:

[Comment 1 Gustavo Ribeiro Alves 2005-10-02 14:02:17 UTC]

Created attachment 69751 [details, diff]
Proposed patch

[Comment 2 Gustavo Ribeiro Alves 2005-10-02 14:04:18 UTC]

Created attachment 69752 [details]
New ebuild

I'm not sure if this should be named libgeda-20050313-r1.ebuild or
libgeda-20050313.ebuild (since it was a compile problem). It compiles cleanly
on my system (it is an amd64, so I suggest adding ~amd64 and masking it for
testing purposes).

[Comment 3 Mark Loeser (RETIRED) 2005-10-02 14:51:11 UTC]

Patch looks good.  Upstream has already made the change in their CVS.

[Comment 4 Gustavo Ribeiro Alves 2005-10-02 17:42:47 UTC]

Please take a look at:

http://bugs.gentoo.org/show_bug.cgi?id=107929

[Comment 5 Tim Yamin (RETIRED) 2005-11-04 14:01:57 UTC]

Gustavo, am I correct in assuming that 20050820 fixes this issue?

[Comment 6 Gustavo Ribeiro Alves 2005-11-05 18:26:43 UTC]

Yes, it appears to be fixed at 20050820.

[Comment 7 Tim Yamin (RETIRED) 2005-11-06 06:03:41 UTC]

*** This bug has been marked as a duplicate of 107929 ***