Bug 102825 – net-analyzer/acid depends on =dev-php/mod-php-4* instead of virtual/httpd-php

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Jakub Moc (RETIRED) 2005-08-17 05:57:07 UTC]

Please, fix the dependency. Also the internal checks in pkg_setup() need to be
corrected. 

Reproducible: Always
Steps to Reproduce:

[Comment 1 Jakub Moc (RETIRED) 2005-09-06 10:27:06 UTC]

OK, the new PHP ebuilds are in portage and will be removed from package.mask in
two days (Thursday, Sept. 8). This needs an urgent fix so that we don't break
the dependency tree for ~arch users.

Mass ping. ;)

[Comment 2 Marcelo Goes (RETIRED) 2005-09-08 14:36:15 UTC]

Hi,

I am not too sure how to proceed here.
For example, pkg_setup() includes a "built_with_use dev-php/mod_php gd"
condition, is replacing dev-php/mod_php with virtual/httpd-php a plausible option?

Better yet, would you mind attaching a patch? :-)

Thanks,
Marcelo

[Comment 3 Jakub Moc (RETIRED) 2005-09-08 15:24:21 UTC]

Created attachment 67964 [details, diff]
acid-0.9.6_beta23.ebuild.diff

OK, here's the patch. I don't understand though, why the checks for mod_php-5*
w/ session use flags were added in the original ebuild, because the ebuild did
specifically depend on mod_php-4*. 

If this actually works w/ php-5, then drop "need_php4" from the patch and
adjust the RDEPEND accordingly. Check for session use flag was added now
anyway, b/c dev-lang/php-4* has this use flag as well.

Thanks.

[Comment 4 Marcelo Goes (RETIRED) 2005-09-08 16:16:39 UTC]

To be frank, neither do I. Thanks for the patch and the php magic. I can't
really test it with php-5 right now, but at least your patch is in so that this
ebuild won't burst into flames.

[Comment 5 Jakub Moc (RETIRED) 2005-09-13 01:32:48 UTC]

OK, this needs a bit more lovin'. ;) dev-php/jpgraph will be "splitted" into
dev-php{4,5}/jpgraph, as there are different versions incompatible with the
other php version. (In fact, this has already been done in PHP overlay). If this
just works w/ php4, it'll be pretty simple, otherwise some eclass magic will be
needed.

I'll keep you posted. :)

[Comment 6 Jakub Moc (RETIRED) 2005-09-19 05:07:54 UTC]

Created attachment 68802 [details, diff]
patch for acid-0.9.6_beta23-r1 ebuild

Fixed need_php4, inherits depend.apache, adapted for new dev-php4/jpgraph
ebuild, fixed dependency on adodb to version that is compatible w/
dev-lang/php.

Please, revbump this, the changes are really substantial now.

[Comment 7 Jakub Moc (RETIRED) 2005-09-19 05:25:35 UTC]

OK, please don't keyword ~ppc and ~amd64 until dev-php4/jpgraph and
=dev-php/adodb-4.65-r1 are keyworded. Will file a bug for them.

[Comment 8 Marcelo Goes (RETIRED) 2005-09-19 11:54:14 UTC]

Created attachment 68820 [details, diff]
acid-0.9.6_beta23-r1.ebuild.diff

I'm actually having a problem with apache (I unmerged it along with mod_php and
php to work around a blocker) and I can't emerge it. If anyone can test this,
feel free to commit.

[Comment 9 Jakub Moc (RETIRED) 2005-12-01 23:18:53 UTC]

Finally got to this...

Please, replace the pkg_setup with the following and all will be set:

pkg_setup() {
        webapp_pkg_setup
        require_gd
        require_php_with_use session
}

require_gd allows for install with dev-lang/php compiled with either USE=gd or
USE=gd-external, both have necessary gd support.

Thanks.

[Comment 10 Jakub Moc (RETIRED) 2006-01-04 11:44:20 UTC]

Created attachment 76171 [details, diff]
patch - final version :)

[Comment 11 Daniel Black (RETIRED) 2006-01-04 11:50:02 UTC]

added - thanks Jakub.

[Comment 12 Jakub Moc (RETIRED) 2006-02-07 12:08:49 UTC]

@ppc: Please, re-keyword 0.9.6_beta23-r1 now that dev-php4/jpgraph is keyworded... Thanks.

[Comment 13 Joe Jezak (RETIRED) 2006-02-17 08:35:37 UTC]

Marked ~ppc, transfering the bug back to php-bugs, I'm not sure if they want to close it yet.

[Comment 14 Jakub Moc (RETIRED) 2006-02-17 08:42:35 UTC]

Closing, this has never been keyworded stable. Thanks.