Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 101812 - export generic_drop_inode() patch
Summary: export generic_drop_inode() patch
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Gentoo Kernel Bug Wranglers and Kernel Maintainers
URL:
Whiteboard:
Keywords: Inclusion
Depends on:
Blocks: 98024
  Show dependency tree
 
Reported: 2005-08-08 17:45 UTC by Lazar Obradovic
Modified: 2005-08-29 08:51 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---

Attachments
patch that exports generic_drop_inode (export_generic_drop_inode.patch,1.00 KB, patch)
2005-08-08 17:46 UTC, Lazar Obradovic 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lazar Obradovic 2005-08-08 17:45:16 UTC 
Hello, 

could you please include attached patch in gentoo-sources?
It's required by ocfs2. It exports generic_drop_inode() from fs/inode.c.
This 'bug' is currently blocking bz#98024
Comment 1 Lazar Obradovic 2005-08-08 17:46:59 UTC 
Created attachment 65492 [details, diff]
patch that exports generic_drop_inode

Patch against gentoo-sources-2.6.12-r6. 
It's offset adjusted version of patch included with ocfs2, available from: 
http://oss.oracle.com/projects/ocfs2/dist/files/source/ocfs2-1.0.0.tar.gz
Comment 2 Greg Kroah-Hartman (RETIRED) gentoo-dev 2005-08-08 21:44:49 UTC 
Is this patch upstream yet?

I would not recommend exporting anything so core to the kernel unless the kernel maintainers 
upstream
agree with this.
Comment 3 Lazar Obradovic 2005-08-09 00:53:30 UTC 
As from what I can see, it is since 2.6.13-r3: 

commit cb2c0233755429037462e16ea0d5497a0092738c
Author: Mark Fasheh <mark.fasheh@oracle.com>
Date:   Thu Jul 7 17:56:03 2005 -0700

    [PATCH] export generic_drop_inode() to modules
    
    OCFS2 wants to mark an inode which has been orphaned by another node so
    that during final iput it takes the correct path through the VFS and can
    pass through the OCFS2 delete_inode callback.  Since i_nlink can get out of
    date with other nodes, the best way I see to accomplish this is by clearing
    i_nlink on those inodes at drop_inode time.  Other than this small amount
    of work, nothing different needs to happen, so I think it would be cleanest
    to be able to just call generic_drop_inode at the end of the OCFS2
    drop_inode callback.
    
    Signed-off-by: Mark Fasheh <mark.fasheh@oracle.com>
    Signed-off-by: Andrew Morton <akpm@osdl.org>
    Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Comment 4 Daniel Drake (RETIRED) gentoo-dev 2005-08-29 08:51:22 UTC 
gentoo-sources-2.6.13 now in portage