Summary: | dev-libs/libgit2-1.8.0: fails tests with LTO | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Sam James <sam> |
Component: | Current packages | Assignee: | Michał Górny <mgorny> |
Status: | CONFIRMED --- | ||
Severity: | normal | CC: | esigra, gnome, kripton |
Priority: | Normal | Keywords: | TESTFAILURE |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 618550, 915000 | ||
Attachments: |
build.log.xz
LastTest.log.xz |
Description
Sam James
2024-03-25 15:36:52 UTC
Created attachment 888555 [details]
build.log.xz
Created attachment 888556 [details]
LastTest.log.xz
$ ./libgit2_tests -spack::midx::writer -spack::midx::odb_create -spack::sharing::open_two_repos Loaded 382 suites: Started (test status codes: OK='.' FAILURE='F' SKIPPED='S') FFF 1) Failure: pack::midx::writer [/var/tmp/portage/dev-libs/libgit2-1.8.0/work/libgit2-1.8.0/tests/libgit2/pack/midx.c:75] midx.size != git_str_len(&expected_midx) 1268 != 47188 2) Failure: pack::midx::odb_create [/var/tmp/portage/dev-libs/libgit2-1.8.0/work/libgit2-1.8.0/tests/libgit2/pack/midx.c:100] Function call failed: (git_odb_write_multi_pack_index(odb)) error -1 - invalid multi-pack-index file - chunks extend beyond the trailer 3) Failure: pack::sharing::open_two_repos [/var/tmp/portage/dev-libs/libgit2-1.8.0/work/libgit2-1.8.0/tests/libgit2/pack/sharing.c:30] 2 != pack->refcount.val 2 != 3 -fno-strict-aliasing works... I finally managed to reproduce it manually, the catch was -DNDEBUG. (export CFLAGS="-O3 -flto=jobserver"; cmake -DCMAKE_C_FLAGS_RELWITHDEBINFO="" -G Ninja -DBUILD_TESTS=yes -DUSE_SSH=yes -DUSE_GSSAPI=OFF -DUSE_HTTP_PARSER=system -DREGEX_BACKEND=pcre2 -DCMAKE_BUILD_TYPE=RelWithDebInfo -B build; ninja -C build) at 1.8.0 tag (In reply to Sam James from comment #4) > -fno-strict-aliasing works... While trying to figure out if it's an aliasing violation, I hit https://gcc.gnu.org/PR114493 :( The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8eee7939509b0575edf7dffc8d09b35e50e05e2b commit 8eee7939509b0575edf7dffc8d09b35e50e05e2b Author: Sam James <sam@gentoo.org> AuthorDate: 2024-03-29 04:17:29 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2024-03-29 04:17:29 +0000 dev-libs/libgit2: filter LTO, no SA Test failures with -O3 -flto. I'm going to keep the bug open for a bit longer pending investigation though. Bug: https://bugs.gentoo.org/927821 Signed-off-by: Sam James <sam@gentoo.org> dev-libs/libgit2/libgit2-1.7.2.ebuild | 3 +++ dev-libs/libgit2/libgit2-1.8.0.ebuild | 3 +++ 2 files changed, 6 insertions(+) |