Bug 902811

Summary:	sys-fs/multipath-tools-0.9.4-r1 adds -Werror flag on its own
Product:	Gentoo Linux	Reporter:	Agostino Sarubbo <ago>
Component:	Current packages	Assignee:	Gentoo's Team for Core System packages <base-system>
Status:	RESOLVED FIXED
Severity:	normal	CC:	esigra, sam
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
See Also:	https://bugs.gentoo.org/show_bug.cgi?id=880567
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	260867
Attachments:	build.log

Description Agostino Sarubbo gentoo-dev

2023-03-23 12:29:49 UTC

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: sys-fs/multipath-tools-0.9.4 adds -Werror flag on its own.
Discovered on: amd64 (internal ref: ci)

NOTE:
-Werror is not recommended for releases and should always be disabled when encountered in build-logs, because there are numerous cases where this breaks without purpose.
See also: https://devmanual.gentoo.org/ebuild-writing/common-mistakes/index.html.

Comment 1 Agostino Sarubbo gentoo-dev

2023-03-23 12:29:52 UTC

Created attachment 858693 [details]
build.log

build log and emerge --info

Comment 2 Agostino Sarubbo gentoo-dev

2023-03-23 15:51:48 UTC

ci has reproduced this issue with version 0.9.4-r1 - Updating summary.

Comment 3 Larry the Git Cow gentoo-dev

2023-03-23 15:54:55 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1bb1ddae1e788f78eb2f7dd47f2f2f92e5fc7a94

commit 1bb1ddae1e788f78eb2f7dd47f2f2f92e5fc7a94
Author:     David Seifert <soap@gentoo.org>
AuthorDate: 2023-03-23 15:54:48 +0000
Commit:     David Seifert <soap@gentoo.org>
CommitDate: 2023-03-23 15:54:48 +0000

    sys-fs/multipath-tools: remove -Werror from build
    
    Closes: https://bugs.gentoo.org/902811
    Signed-off-by: David Seifert <soap@gentoo.org>

 .../multipath-tools-0.9.4-remove-Werror.patch      | 45 ++++++++++++++++++++++
 .../multipath-tools-0.9.4-r1.ebuild                |  6 +--
 2 files changed, 47 insertions(+), 4 deletions(-)