Bug 895014

Summary:	sci-electronics/kicad-7.0.0-r1 adds -Werror flag on its own
Product:	Gentoo Linux	Reporter:	Agostino Sarubbo <ago>
Component:	Current packages	Assignee:	Zoltan Puskas <zoltan>
Status:	RESOLVED FIXED
Severity:	normal	CC:	esigra, matthew, proxy-maint, sam
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	260867
Attachments:	build.log.xz

Description Agostino Sarubbo gentoo-dev

2023-02-17 07:46:59 UTC

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: sci-electronics/kicad-7.0.0 adds -Werror flag on its own.
Discovered on: amd64 (internal ref: ci)

NOTE:
-Werror is not recommended for releases and should always be disabled when encountered in build-logs, because there are numerous cases where this breaks without purpose.
See also: https://devmanual.gentoo.org/ebuild-writing/common-mistakes/index.html.

Comment 1 Agostino Sarubbo gentoo-dev

2023-02-17 07:47:02 UTC

Created attachment 851926 [details]
build.log.xz

build log and emerge --info (compressed because it exceeds attachment limit, use 'xzless' to read it)

Comment 2 Agostino Sarubbo gentoo-dev

2023-02-18 13:54:47 UTC

ci has reproduced this issue with version 7.0.0-r1 - Updating summary.

Comment 3 Larry the Git Cow gentoo-dev

2023-02-21 17:56:48 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=996b5c04c7f5fb478244ff8372db0af3eaa130bd

commit 996b5c04c7f5fb478244ff8372db0af3eaa130bd
Author:     Matthew Smith <matthew@gentoo.org>
AuthorDate: 2023-02-20 18:33:52 +0000
Commit:     Matthew Smith <matthew@gentoo.org>
CommitDate: 2023-02-21 17:56:24 +0000

    sci-electronics/kicad: remove -Werror
    
    Closes: https://bugs.gentoo.org/895014
    Acked-by: Zoltan Puskas <zoltan@sinustrom.info>
    Signed-off-by: Matthew Smith <matthew@gentoo.org>

 .../kicad/files/kicad-7.0.0-werror.patch            | 21 +++++++++++++++++++++
 sci-electronics/kicad/kicad-7.0.0-r1.ebuild         |  2 ++
 2 files changed, 23 insertions(+)