Bug 620814

Summary:	media-sound/helm: binary file in gentoo repository
Product:	Gentoo Linux	Reporter:	Ulrich Müller <ulm>
Component:	Current packages	Assignee:	Professional Audio Applications Maintainers <proaudio>
Status:	RESOLVED FIXED
Severity:	QA	CC:	plevine457, qa
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
URL:	https://qa-reports.gentoo.org/output/find-binary-files.txt
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	331331

Description Ulrich Müller gentoo-dev

2017-06-04 17:06:02 UTC

As reported, see URL: 
media-sound/helm/files/helm-0.4.1-gcc6.patch: application/octet-stream; charset=binary (size=992)

Policy reference:
https://devmanual.gentoo.org/general-concepts/tree/index.html#what-belongs-in-the-tree%3F

Comment 1 Ulrich Müller gentoo-dev

2017-06-06 07:35:24 UTC

Looks like the bad file originates from this PR:
https://github.com/gentoo/gentoo/pull/4754

Comment 2 Peter Levine 2017-06-06 16:07:25 UTC

(In reply to Ulrich Müller from comment #1)
> Looks like the bad file originates from this PR:
> https://github.com/gentoo/gentoo/pull/4754

That's mine.  The patch is a pretty straight forward text file.  How is it that that is being interpreted as a binary file?

Comment 3 Ulrich Müller gentoo-dev

2017-06-06 19:29:32 UTC

(In reply to Peter Levine from comment #2)
> The patch is a pretty straight forward text file.  How is it that that is
> being interpreted as a binary file?

The file contained some garbage characters in the commit message (which are not visible in github's web interface). No idea if they were there in the original patch, or if it's some later corruption.

It should be fixed now:
https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=83b1bbf35b53f7becef8bba1f5c11ede1d57e0e1

Comment 4 Peter Levine 2017-06-07 00:21:38 UTC

(In reply to Ulrich Müller from comment #3)
> (In reply to Peter Levine from comment #2)
> > The patch is a pretty straight forward text file.  How is it that that is
> > being interpreted as a binary file?
> 
> The file contained some garbage characters in the commit message (which are
> not visible in github's web interface). No idea if they were there in the
> original patch, or if it's some later corruption.
> 
> It should be fixed now:
> https://gitweb.gentoo.org/repo/gentoo.git/commit/
> ?id=83b1bbf35b53f7becef8bba1f5c11ede1d57e0e1

OK.  It might have been a Unicode BOM which I accidentally enabled a while back.