Bug 599938

Summary:	x11-drivers/xf86-input-keyboard-1.8.1: build fails with >=x11-base/xorg-server-1.19.0
Product:	Gentoo Linux	Reporter:	Alexander Turenko <totktonada.ru>
Component:	Current packages	Assignee:	Gentoo X packagers <x11>
Status:	RESOLVED FIXED
Severity:	normal	CC:	Adrian.Bassett, dominik, hanno, holger, jan, jfostiguy, johnnybit, lekto, toralf, zeekec
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
URL:	https://cgit.freedesktop.org/xorg/driver/xf86-input-keyboard/commit/?id=157e0631b12d0aae4a5f38b81bee615a7eaf553f
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	599976
Attachments:	Proposed patch, for convenience

Description Alexander Turenko 2016-11-16 03:41:03 UTC

The patch from URL field makes it able to be built.

Comment 1 Kamil Kamiński 2016-11-16 08:57:06 UTC

Created attachment 453430 [details, diff]
Proposed patch, for convenience

After applying, xf86-input-keyboard-1.8.1 builds fine.

Comment 2 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev

2016-11-16 10:55:29 UTC

*** Bug 599954 has been marked as a duplicate of this bug. ***

Comment 3 Alex Turbov 2016-11-16 18:28:07 UTC

+1 (patch works for me)

Comment 4 lekto 2016-11-16 22:18:14 UTC

Patch works for me on nomultilib too.

Comment 5 max parmer 2016-11-17 01:17:32 UTC

Build was failing with:

> /var/tmp/portage/x11-drivers/xf86-input-keyboard-1.8.1/work/xf86-input-keyboard-1.8.1/src/kbd.c: In function 'KbdProc':
> /var/tmp/portage/x11-drivers/xf86-input-keyboard-1.8.1/work/xf86-input-keyboard-1.8.1/src/kbd.c:386:2: error: implicit declaration of function 'AddEnabledDevice' [-Werror=implicit-function-decla
ration]
>   AddEnabledDevice(pInfo->fd);
>   ^
> /var/tmp/portage/x11-drivers/xf86-input-keyboard-1.8.1/work/xf86-input-keyboard-1.8.1/src/kbd.c:386:2: warning: nested extern declaration of 'AddEnabledDevice' [-Wnested-externs]
> /var/tmp/portage/x11-drivers/xf86-input-keyboard-1.8.1/work/xf86-input-keyboard-1.8.1/src/kbd.c:400:7: error: implicit declaration of function 'RemoveEnabledDevice' [-Werror=implicit-function-de
claration]
>        RemoveEnabledDevice(pInfo->fd);
>        ^
> /var/tmp/portage/x11-drivers/xf86-input-keyboard-1.8.1/work/xf86-input-keyboard-1.8.1/src/kbd.c:400:7: warning: nested extern declaration of 'RemoveEnabledDevice' [-Wnested-externs]
> cc1: some warnings being treated as errors

Proposed patch resolves this.

Comment 6 cam++ 2016-11-17 16:36:32 UTC

Simple, install xf86-input-keyboard.1.9.0 !!

Comment 7 Toralf Förster gentoo-dev

2016-11-17 16:45:30 UTC

This is a tinderbox.
If a package fails it should correct its (r)deps.

Comment 8 Ooblick 2016-11-17 16:52:27 UTC

xf86-input-keyboard-1.9 is released https://www.x.org/releases/individual/driver/xf86-input-keyboard-1.9.0.tar.bz2

Comment 9 Alexander Turenko 2016-11-17 16:53:41 UTC

Yep, the upstream tagged 1.9.0 12 hours ago :)

Comment 10 Manuel Rüger (RETIRED) gentoo-dev

2016-11-17 21:50:32 UTC

commit 3e8ece145d930f6ad7d25133c11d2a0a7e6db83a
Author: Manuel Rüger <mrueg@gentoo.org>
Date:   Thu Nov 17 22:41:37 2016 +0100

    x11-drivers/xf86-input-keyboard: Version bump to 1.9.0
    
    Supports xorg-server-1.19
    
    Gentoo-Bug: 599938
    
    Package-Manager: portage-2.3.2