| Summary: | pppoatm plugin isn't built with ppp on non-x86 architectures, even with 'atm' in use flags | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Marc Ozon <marc_ozon> |
| Component: | Current packages | Assignee: | Gentoo Dialup Developers <net-dialup> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | ||
| Priority: | High | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: | diff for ppp-2.4.2-r2.ebuild without x86 requirement for atm | ||
Created attachment 34637 [details, diff]
diff for ppp-2.4.2-r2.ebuild without x86 requirement for atm
Patch for ppp-2.4.2-r2.ebuild, with x86 requirement for atm support removed.
Same thing for amd64, it build and works... fixed. |
The atm support in the latest ppp ebuilds is explicitly enabled only for x86, separately from keywords and use flags. For example, ppp-2.4.2-r2.ebuild has on lines 32-36: if use atm && use x86; then einfo "Enabling PPPoATM support" epatch ${FILESDIR}/${PV}/pppoatm-2.diff.gz sed -i -e "s/^LIBS =/LIBS = -latm/" pppd/Makefile.linux || die fi And on lines 103-105: if use atm && use x86; then dolib.so pppd/plugins/pppoatm.so fi The result: on any architecture other than x86, putting 'atm' in $USE won't result in the pppoatm plugin being built or installed, without any warning or explanation why it's set to be x86-only. The requirement for x86 appears to be unnecessary: the atm plugin should build and work on other architectures. I've checked on ppc (just removed the '&& use x86' checks from the ebuild on the two lines quoted above), and it all seems to work fine -- the patch applies and the plugin builds, each without any problems, and ppp seems to work with the pppoatm.so plugin.