Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 55881 - pppoatm plugin isn't built with ppp on non-x86 architectures, even with 'atm' in use flags
Summary: pppoatm plugin isn't built with ppp on non-x86 architectures, even with 'atm'...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo Dialup Developers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-07-02 07:12 UTC by Marc Ozon
Modified: 2004-09-27 03:37 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
diff for ppp-2.4.2-r2.ebuild without x86 requirement for atm (ppp-atm.diff,1.44 KB, patch)
2004-07-02 07:20 UTC, Marc Ozon
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Marc Ozon 2004-07-02 07:12:01 UTC
The atm support in the latest ppp ebuilds is explicitly enabled only for x86, separately from keywords and use flags.  For example, ppp-2.4.2-r2.ebuild has on lines 32-36:

    if use atm && use x86; then
        einfo "Enabling PPPoATM support"
        epatch ${FILESDIR}/${PV}/pppoatm-2.diff.gz
        sed -i -e "s/^LIBS =/LIBS = -latm/" pppd/Makefile.linux || die
    fi

And on lines 103-105:

    if use atm && use x86; then
        dolib.so pppd/plugins/pppoatm.so
    fi

The result:  on any architecture other than x86, putting 'atm' in $USE won't result in the pppoatm plugin being built or installed, without any warning or explanation why it's set to be x86-only.

The requirement for x86 appears to be unnecessary:  the atm plugin should build and work on other architectures.  I've checked on ppc (just removed the '&& use x86' checks from the ebuild on the two lines quoted above), and it all seems to work fine -- the patch applies and the plugin builds, each without any problems, and ppp seems to work with the pppoatm.so plugin.
Comment 1 Marc Ozon 2004-07-02 07:20:11 UTC
Created attachment 34637 [details, diff]
diff for ppp-2.4.2-r2.ebuild without x86 requirement for atm

Patch for ppp-2.4.2-r2.ebuild, with x86 requirement for atm support removed.
Comment 2 PhilGunnm 2004-07-05 06:52:07 UTC
Same thing for amd64, it build and works...
Comment 3 Heinrich Wendel (RETIRED) gentoo-dev 2004-09-27 03:37:41 UTC
fixed.