Summary: | media-video/ffmpeg: add bindist restriction | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Ulrich Müller <ulm> |
Component: | Current packages | Assignee: | Gentoo Media-video project <media-video> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | qa |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 541408 |
Description
Ulrich Müller
2015-02-28 08:03:01 UTC
where is this documented/announced ? if the point is just to tell 'if use foo, then you cant bindist', since ffmpeg uses bindist only for required_use, it is much better to kill the bindist useflag have a proper RESTRICT=... line. removing qacanfix tag since the proper solution is still unclear. (In reply to Alexis Ballier from comment #1) > if the point is just to tell 'if use foo, then you cant bindist', since > ffmpeg uses bindist only for required_use, it is much better to kill the > bindist useflag have a proper RESTRICT=... line. I went for the minimal change here, namely adding a RESTRICT line. Removing the bindist flag should be discussed in the -dev ML. I'll send an announcement later today. (In reply to Ulrich Müller from comment #2) > Removing the bindist flag should be discussed in the -dev ML. I'll send an > announcement later today. hu ? this cannot be done for e.g. openssl, where the flag is used inside the ebuild. I was merely talking about the package this bug report is about. (In reply to Alexis Ballier from comment #3) > (In reply to Ulrich Müller from comment #2) > > Removing the bindist flag should be discussed in the -dev ML. I'll send an > > announcement later today. > > > hu ? > this cannot be done for e.g. openssl, where the flag is used inside the > ebuild. I was merely talking about the package this bug report is about. It is a more general problem. We have several ebuilds that follow a scheme like the following: http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/net-dialup/freeradius/freeradius-3.0.3.ebuild?revision=1.3&view=markup In a nutshell, they currently have (similar to ffmpeg, but simpler): IUSE="bindist foo" REQUIRED_USE="bindist? ( !foo )" Except for the REQUIRED_USE, the bindist flag is otherwise not used in the ebuild. The question is if we should simply add a restriction: IUSE="bindist foo" REQUIRED_USE="bindist? ( !foo )" RESTRICT="!bindist? ( bindist )" Or alternatively, we could remove the bindist flag: IUSE="foo" RESTRICT="foo? ( bindist )" (In reply to Ulrich Müller from comment #4) ok; i wasn't even considering the former since i don't see the point of such duplication: it could very well be handled internally by PM just like FEATURES=test -> USE=test also, aren't allowed values of RESTRICT defined by PMS ? in which case, what EAPI should be used ? Following up to the discussion in gentoo-dev, please add this line to ebuilds: RESTRICT="encode? ( faac? ( bindist ) aacplus? ( bindist ) ) openssl? ( bindist )" and remove the bindist flag from IUSE and REQUIRED_USE. done |