Bug 51852 - sdl-mixer has a broken dependency
Bug#: 51852 Product:  Gentoo Linux Version: unspecified Platform: All
OS/Version: All Status: RESOLVED Severity: normal Priority: P2
Resolution: FIXED Assigned To: games@gentoo.org Reported By: pauldv@gentoo.org
Component: Games
URL: 
Summary: sdl-mixer has a broken dependency
Keywords:  
Status Whiteboard: 
Opened: 2004-05-23 13:29 0000
Description:   Opened: 2004-05-23 13:29 0000 
Ok, while sdl-mixer claims to depend on libmikmod. It actually doesn't. It
includes an old version of libmikmod and links it in statically. This causes
for example that the mod garbling on amd64 will not be fixed by the libmikmod
patch.

There are two options to fix sdl-mixer. First to remove the mikmod dependency
from sdl-mixer. Another one, rather, but more dangerous (should be tested
first) is to apply some patches to make it build against an external mikmod.
I'll attach the needed patchfile, but it also changes some parts of the source
so that's where the danger is. I didn't thoroughly test the patches on the area
of building with other packages and running well.

------- Comment #1 From Paul de Vrieze 2004-05-23 13:30:53 0000 ------- 
Created an attachment (id=31901) [details]
1.2.5-libmikmod.patch

The patch that enables building against the external libmikmod

------- Comment #2 From Paul de Vrieze 2004-05-23 13:31:54 0000 ------- 
Created an attachment (id=31903) [details]
sdl-mixer-1.2.5-r2.ebuild

The ebuild that applies the patch. Note that it also has added die options if
the patching fails !!!

------- Comment #3 From SpanKY 2004-05-23 15:53:19 0000 ------- 
used a slightly different patch and added to portage, thanks

------- Comment #4 From Derek Dolney 2004-05-24 07:37:17 0000 ------- 
The new ebuild does not work if the user does not USE mikmod. I have "-mikmod"
in my make.conf, and emerge fails with the error

ld: cannot find -lmikmod

------- Comment #5 From SpanKY 2004-05-24 15:08:24 0000 ------- 
i suck at life

------- Comment #6 From SpanKY 2004-05-24 15:27:12 0000 ------- 
seems to be an autoconf bug ... i'll poke around

------- Comment #7 From stan 2004-05-25 07:24:39 0000 ------- 
Re: Comment #4
in case this hasn't already been fixed:

use_enable line in sdl-mixer-1.2.5-r2.ebuild for mikmod appears to run correctly with `use_enable mikmod music-mod` rather than `use_enable mikmod mod` for users with USE="-mikmod"

------- Comment #8 From Horace Ip 2004-05-25 07:36:22 0000 ------- 
After upgrading to r2, I get these from tuxracer but not from r1. No music is
played and I can never enter a race in tuxracer, it just halt.

%%% tuxracer warning: FAILED to load music file music/start1-jt.it: No error
%%% tuxracer warning: FAILED to load music file music/options1-jt.it: No error
%%% tuxracer warning: FAILED to load music file music/race1-jt.it: No error
%%% tuxracer warning: FAILED to load music file music/wonrace1-jt.it: No error

------- Comment #9 From SpanKY 2004-05-25 14:37:42 0000 ------- 
ah it was a bug in the ebuild ... the configure option is 'music-mod' not 'mod'

fixed in cvs, sorry about that

------- Comment #10 From SpanKY 2004-08-11 19:34:37 0000 ------- 
totally breaks stuff

------- Comment #11 From SpanKY 2004-08-11 19:34:43 0000 ------- 
*** Bug 52064 has been marked as a duplicate of this bug. ***

------- Comment #12 From SpanKY 2004-11-07 21:53:40 0000 ------- 
1.2.5-r1 includes a patch which fixes amd64 issues

as for not using system mikmod, we'll let upstream handle that