Bug 52064 – sdl-mixer-1.2.5-r2 update messed up with mikmod

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Gustavo Ribeiro Alves 2004-05-25 22:24:17 UTC]

After last sdl-mixer update supertux and other games stoped loading MOD files.

Changelog of sdl-mixer update suggests change on mikmod.

Downgrading sdl-mixer to 1.2.5-r1 solved the problem.

Reproducible: Always
Steps to Reproduce:

[Comment 1 SpanKY 2004-05-25 22:40:25 UTC]

paul: what did i break ? :)

[Comment 2 Paul de Vrieze (RETIRED) 2004-05-26 01:24:01 UTC]

Apparently the use of libmikmod instead of the internal version is not as straightforward as appeared. I suggest to mask -r2 until we can make it work.

[Comment 3 Charles Goodwin 2004-05-26 19:11:17 UTC]

This breaks pretty much every SDL game's sound for me, causing most of them to crash.

[Comment 4 SpanKY 2004-05-26 19:21:55 UTC]

1.2.5-r2 has been packaged masked

[Comment 5 SpanKY 2004-05-26 19:22:58 UTC]

*** Bug 52082 has been marked as a duplicate of this bug. ***

[Comment 6 Tyler Montbriand 2004-05-27 11:29:13 UTC]

This bug also exists with sdl-mixer-1.2.5-r3.  I commented out the line 

epatch ${FILESDIR}/${PV}-system-mikmod.patch

in sdl-mixer-1.2.5-r3.ebuild and mods started working again in tuxracer, etc.
The exact same line is present in sdl-mixer-1.2.5-r2.  Suggest leaving out this
"fix", all it does is break things.

[Comment 7 Gustavo Ribeiro Alves 2004-05-27 11:35:11 UTC]

I was going to comment on the bug being on sdl-mixer but someone was faster than me :). 

Also, shouldn't the AMD64 patches be applied only when the arch is amd64?

[Comment 8 Tyler Montbriand 2004-05-27 11:51:42 UTC]

All the patches do is patch the ifdefs to let it detect native 64-bit under amd64; they don't alter the code in any proprietary amd64 way, so what's the harm?  Easier to just patch everything.

[Comment 9 Paul de Vrieze (RETIRED) 2004-05-27 11:54:49 UTC]

The system-mikmod patch is not really amd64 only. It was a simple attempt at trying to put some sanity in sdl-mixer. It sadly fails, so more work is probably needed to make it work with the system libmikmod.

[Comment 10 Gustavo Ribeiro Alves 2004-05-27 12:33:56 UTC]

What does this part of the patch does?

--- SDL_mixer-1.2.5.orig/music.c.orig	2004-05-23 18:41:25.760726312 -0400
+++ SDL_mixer-1.2.5/music.c	2004-05-23 18:43:37.272733448 -0400
@@ -1058,4 +1058,7 @@
 }
 
+static int _pl_synchro_value;
+#define Player_SetSynchroValue(x) _pl_synchro_value=x;
+#define Player_GetSynchroValue() _pl_synchro_value;
 int Mix_SetSynchroValue(int i)
 {
@@ -1110,8 +1111,8 @@
 #endif
 #ifdef MOD_MUSIC
 	MikMod_Exit();
-	MikMod_UnregisterAllLoaders();
-	MikMod_UnregisterAllDrivers();
+//	MikMod_UnregisterAllLoaders();
+//	MikMod_UnregisterAllDrivers();
 #endif
 }

?
To me it's only defining a global variable ( static int _pl_synchro_value; )

I'll try to compile without it and post the results.

[Comment 11 Paul de Vrieze (RETIRED) 2004-05-27 12:38:18 UTC]

It moves a (seemingly pointless) piece of source from the internal mikmod implementation to the client file, such as to give the interface. The last one is because libmikmod does not contain the closing code that the internal mikmod does.

[Comment 12 SpanKY 2004-05-28 13:46:26 UTC]

yeah, the amd64 peeps released -r3 on us :)

i package masked that too and added the amd64 patch to -r1

[Comment 13 SpanKY 2004-08-11 19:34:42 UTC]

*** This bug has been marked as a duplicate of 51852 ***

[Comment 14 Mr. Bones. (RETIRED) 2005-05-19 09:06:24 UTC]

Closing to clean up after bugzilla upgrade.  reopen if closed in error.  Thanks.

[Comment 15 Mr. Bones. (RETIRED) 2011-09-14 20:38:50 UTC]

clean up bug list after bugzilla update