Summary: | =sys-libs/timezone-data-2013f version bump | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Dirkjan Ochtman (RETIRED) <djc> |
Component: | New packages | Assignee: | Gentoo Toolchain Maintainers <toolchain> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | arfrever.fta |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
See Also: | https://bugs.gentoo.org/show_bug.cgi?id=487192 | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- |
Description
Dirkjan Ochtman (RETIRED)
2013-09-23 08:49:28 UTC
Fixed. unfortunately, the upgrade is broken in a number of ways. like how leap & posix paths get installed. you should also not deviate from existing style. patches should be named with a $PN prefix. omitting that is not ok. i cleaned it all up for timezone-data-2013f-r1. Commit message: Clean up errors in patch/install, and handle the upgrade from previous versions http://sources.gentoo.org/sys-libs/timezone-data/files/timezone-data-2013f-makefile.patch?rev=1.1 http://sources.gentoo.org/sys-libs/timezone-data/timezone-data-2013f-r1.ebuild?rev=1.1 Thanks for fixing it. Is there any value in keeping the PN in patch file names, except for consistency with existing patches? And how much value is there in that consistency? (In reply to Dirkjan Ochtman from comment #4) see http://dev.gentoo.org/~vapier/clean-patches (In reply to SpanKY from comment #3) You have added: pkg_postinst() { rm -rf "${EROOT}"/usr/share/zoneinfo/.gentoo-upgrade } But at the end of ebuild there is: pkg_postinst() { pkg_config } So ${EROOT}/usr/share/zoneinfo/.gentoo-upgrade directory is left after installation. Commit message: Merge duplicate pkg_postinst funcs http://sources.gentoo.org/sys-libs/timezone-data/timezone-data-2013f-r1.ebuild?r1=1.1&r2=1.2 |