Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 452122

Summary: Deprecating pysqlite:2
Product: Gentoo Linux Reporter: Michał Górny <mgorny>
Component: Current packagesAssignee: Python Gentoo Team <python>
Status: RESOLVED FIXED    
Severity: enhancement CC: kripton
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on: 452126, 452128, 452130, 452132, 452134, 452136, 452138, 452142, 452144, 452146, 452148, 452150, 452152, 452154, 452156, 452158, 452750    
Bug Blocks:    

Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2013-01-14 21:39:13 UTC
From what I was able to understand:

1) pysqlite is py2-only and no longer maintained,

2) built-in sqlite3 module is basically a bundled copy of pysqlite,

3) py2.7 sqlite3 is to be considered API-equiv with pysqlite. py2.6 and older are based on older versions.

Therefore, I'd say we could try to remove it. But for that, we need to scan all the deps first to make sure that they're compatible with built-in sqlite3 module.

If there's at least one package which needs external pysqlite2, there's probably no point in dropping support for it. Otherwise, we could just drop it and always require python[sqlite].
Comment 1 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2013-01-14 21:46:06 UTC
$ grep -L 'python.*\[.*sqlite' $(grep -L PYTHON.*sqlite $( find -name '*.ebuild' -exec grep -l pysqlite {} + ))
./local/sunrise/dev-db/dabo/dabo-0.9.2.ebuild
./local/sunrise/media-sound/poddy/poddy-0.5.1.ebuild
./www-client/seamonkey/seamonkey-2.14-r1.ebuild
./www-client/seamonkey/seamonkey-2.14.1.ebuild
./www-client/seamonkey/seamonkey-2.15.ebuild
./app-misc/gnomecatalog/gnomecatalog-0.3.4.2.ebuild
./app-text/bibus/bibus-1.5.1.ebuild
./app-text/bibus/bibus-1.5.2.ebuild
./dev-db/mysql-workbench/mysql-workbench-5.2.44.ebuild
./dev-db/mysql-workbench/mysql-workbench-5.2.44-r1.ebuild
./dev-db/mysql-workbench/mysql-workbench-5.2.45.ebuild
./mail-client/thunderbird/thunderbird-17.0.2.ebuild
./sys-apps/portage/portage-2.1.11.31.ebuild
./sys-apps/portage/portage-2.1.11.38.ebuild
./sys-apps/portage/portage-2.1.6.7_p1.ebuild
./sys-apps/portage/portage-2.2.0_alpha142.ebuild
./sys-apps/portage/portage-2.2.0_alpha149.ebuild
./sys-apps/portage/portage-9999.ebuild
./sys-apps/portage/portage-2.1.11.40.ebuild
./sys-apps/portage/portage-2.2.0_alpha151.ebuild
./net-mail/offlineimap/offlineimap-6.5.4-r1.ebuild
./net-print/pykota/pykota-1.25_p2437-r1.ebuild
./net-print/pykota/pykota-1.26.ebuild
./games-board/pychess/pychess-0.10.1.ebuild
./games-board/pychess/pychess-0.10.1-r1.ebuild
./dev-python/atpy/atpy-0.9.5.3.ebuild
./dev-python/atpy/atpy-0.9.6.ebuild
./dev-python/turbogears/turbogears-1.0.8.ebuild
./dev-python/adodb-py/adodb-py-2.20.ebuild
./dev-python/mozprofile/mozprofile-0.4.ebuild
./dev-python/kaa-base/kaa-base-0.6.0.ebuild
./media-video/griffith/griffith-0.13.ebuild
./media-video/griffith/griffith-9999.ebuild
./media-tv/xbmc/xbmc-11.0.ebuild
./media-tv/xbmc/xbmc-11.0-r1.ebuild
./media-tv/xbmc/xbmc-12.0_rc2.ebuild
./media-tv/xbmc/xbmc-9999.ebuild
./media-tv/freevo/freevo-1.9.0.ebuild
./media-tv/freevo/freevo-1.7.6.1.ebuild
./net-analyzer/linkchecker/linkchecker-8.2.ebuild
./net-analyzer/linkchecker/linkchecker-8.1.ebuild
./net-analyzer/linkchecker/linkchecker-8.0.ebuild
./net-analyzer/linkchecker/linkchecker-7.9.ebuild
Comment 2 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2013-01-15 23:44:27 UTC
Summary after the first review:

app-misc/gnomecatalog                  pysqlite2
app-text/bibus            sqlite3*     pysqlite2**
dev-db/mysql-workbench    sqlite3      pysqlite2*
dev-python/adodb-py       sqlite3*     pysqlite2
dev-python/atpy           sqlite3
dev-python/kaa-base                    pysqlite2
dev-python/mozprofile     sqlite3*     pysqlite2
games-board/pychess       sqlite3
mail-client/thunderbird   sqlite3*     pysqlite2
media-tv/xbmc             sqlite3
media-video/griffith      sqlite3*     pysqlite2
net-analyzer/linkchecker  sqlite3
net-mail/offlineimap      sqlite3
net-print/pykota                       pysqlite2
www-client/seamonkey      sqlite3*     pysqlite2

* preferred implementation
** supported added by Gentoo patch

So, we have 3 packages which use pysqlite2 for some reason only. We need to check if they support sqlite3 as well.

Most of the packages use sqlite3 only, or prefer it over pysqlite2. mysql-workbench seems to be the only one preferring pysqlite2.
Comment 3 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2013-01-16 20:58:53 UTC
Ok, the only package I wasn't able to really test was kaa-base. Otherwise, all our packages support sqlite3, and most of them even prefer it. I think we can fix the remaining packages to use built-in sqlite3 and drop pysqlite2 completely.

@djc, @floppym: what do you think?
Comment 4 Mike Gilbert gentoo-dev 2013-01-17 07:30:15 UTC
I'm really no more familiar with this than you are. Your conclusion seems sane to me.
Comment 5 Dirkjan Ochtman (RETIRED) gentoo-dev 2013-01-17 09:26:34 UTC
(In reply to comment #4)
> I'm really no more familiar with this than you are. Your conclusion seems
> sane to me.

+1.
Comment 6 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2013-01-17 16:57:16 UTC
And masked for removal.
Comment 7 Dion Moult (RETIRED) gentoo-dev 2013-03-24 10:50:24 UTC
Package removed.