Summary: | ppp-2.4.2 fails to build | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Colin Tinker <g1gsw> |
Component: | New packages | Assignee: | Gentoo Dialup Developers <net-dialup> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | dennis.freise, edge, harrisl, jesse, radek |
Priority: | High | ||
Version: | unspecified | ||
Hardware: | x86 | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
patch to pppd source
patch to ebuild patch to disable activefilter alternative patch |
Description
Colin Tinker
2004-02-12 14:05:53 UTC
Same here. Which linux-headers d'you have installed? Or maybe it's getting them from the /usr/src/linux? same here also: gcc -march=pentium3 -mcpu=pentium4 -mno-sse2 -O2 -pipe -DHAVE_PATHS_H -DIPX_CHANGE -DHAVE_MMAP -I../include -DCHAPMS=1 -DMPPE=1 -DHAS_SHADOW -DHAVE_CRYPT_H=1 -DUSE_CRYPT=1 -DUSE_PAM -DHAVE_MULTILINK -DUSE_TDB=1 -DPLUGIN -DPPP_FILTER -I/usr/include/pcap -DCBCP_SUPPORT -DMAXOCTETS -c -o utils.o utils.c make[1]: *** [demand.o] Error 1 make[1]: *** Waiting for unfinished jobs.... make[1]: Leaving directory `/var/tmp/portage/ppp-2.4.2/work/ppp-2.4.2/pppd' make: *** [all] Error 2 !!! ERROR: net-dialup/ppp-2.4.2 failed. !!! Function src_compile, Line 52, Exitcode 2 !!! (no error message) #emerge info Portage 2.0.50-r1 (default-x86-1.4, gcc-3.3.2, glibc-2.3.3_pre20040207-r0, 2.6.3-rc1-gentoo) ================================================================= System uname: 2.6.3-rc1-gentoo i686 Intel(R) Pentium(R) 4 CPU 2.66GHz Gentoo Base System version 1.4.3.13 Autoconf: sys-devel/autoconf-2.59 Automake: sys-devel/automake-1.8.2 ACCEPT_KEYWORDS="x86 ~x86" AUTOCLEAN="yes" CFLAGS="-march=pentium3 -mcpu=pentium4 -mno-sse2 -O2 -pipe" CHOST="i686-pc-linux-gnu" COMPILER="gcc3" CONFIG_PROTECT="/etc /usr/X11R6/lib/X11/xkb /usr/kde/2/share/config /usr/kde/3.2/share/config /usr/kde/3/share/config /usr/share/config /var/qmail/control" CONFIG_PROTECT_MASK="/etc/gconf /usr/X11R6/bin/startx /etc/env.d" CXXFLAGS="-march=pentium3 -mcpu=pentium4 -mno-sse2 -O2 -pipe" DISTDIR="/usr/portage/distfiles" FEATURES="autoaddcvs ccache sandbox" GENTOO_MIRRORS="http://gentoo.oregonstate.edu http://www.ibiblio.org/pub/Linux/distributions/gentoo" MAKEOPTS="-j2" PKGDIR="/usr/portage/packages" PORTAGE_TMPDIR="/var/tmp" PORTDIR="/usr/portage" PORTDIR_OVERLAY="/usr/local/portage" SYNC="rsync://rsync.gentoo.org/gentoo-portage" USE="X aalib acpi4linux alsa arts avi berkdb cdr crypt cups encode esd foomaticdb gdbm gif gnome gphoto2 gpm gtk gtk2 imlib java jpeg kde libg++ libwww mad mikmod mmx motif mozilla mpeg mplayer ncurses nls oggvorbis opengl oss pam pdflib perl png python qt quicktime readline sdl slang spell sse ssl svga tcltk tcpd truetype wxwindows x86 xine xml xml2 xmms xv zlib" Using sys-kernel/linux-headers-2.4.22 the stuff from net/bpf.h has been moved to pcap-bpf.h (from net-libs/libpcap) FIX: edit ppp-2.4.2/work/ppp-2.4.2/pppd/sys-linux.c and demand.c and replace #include <net/bpf.h> with #include <pcap-bpf.h> This makes it compile at least, I have not tested pppd yet ;) This fix works for me. Thanks Peter. I did have to disregard the two updates to ip-up and ip-down that etc-update wanted to do though. When I accepted them, ppp would dial and connect but apps couldn't see the connection. *shrug* *** Bug 41451 has been marked as a duplicate of this bug. *** *** Bug 41457 has been marked as a duplicate of this bug. *** Created attachment 25569 [details, diff]
patch to pppd source
patch to incorporate the two oneliners above.
place in files/2.4.2/pcap.patch
Created attachment 25570 [details, diff]
patch to ebuild
add epatch line to incorporate patch above
make ebuild depend on libpcap even without the activefilter USE flag set.
Thanks for the patches, they're applied now. Created attachment 25643 [details, diff]
patch to disable activefilter
Created attachment 25647 [details, diff]
alternative patch
I don't think the patch is a good solution. The file pcap-bpf.h is not included
in libpcap 0.7.1 (and 0.8.1 is marked ~x86)
However, pcap.h which is included in both versions includes the correct bpf.h
file in both versions.
IMHO the correct solution is to include pcap.h
I think the ebuild should be modified because the FILTER option is enabled by default in ppp-2.4.2, so maybe the following use activefilter && { einfo "Enabling active-filter" sed -i -e "s/^#FILTER=y/FILTER=y/" pppd/Makefile.linux || die } should be replaced with: use activefilter || { einfo "Disabling active-filter" sed -i -e "s/^FILTER=y/#FILTER=y/" pppd/Makefile.linux } *** Bug 41635 has been marked as a duplicate of this bug. *** Still getting this error, but it was marked as RESOLVED FIXED. Notes don't indicate a fix. Is it fixed? Thank's! It's OK now. PPP maked successfully after emerge sync. I don't know how this got jacked, but plz remove depend on libpcap. activefilter should be off by default, and it should be activefilter?(dev-libs/libpcap) for the depends. I was trying to go this way when I rewrote it, however I couldnt get any testing peeps on activefilter portion, so it was never completed. Please change asap,thanks:) I'm getting a build problem that seems related to this, though my problem may simply be that I don't normally run ~x86. My compilation dies with this message: ---------------------------------------------------------- demand.c:53:22: pcap-bpf.h: No such file or directory make[1]: *** [demand.o] Error 1 make[1]: *** Waiting for unfinished jobs.... make[1]: Leaving directory `/var/tmp/portage/ppp-2.4.2/work/ppp-2.4.2/pppd' make: *** [all] Error 2 !!! ERROR: net-dialup/ppp-2.4.2 failed. !!! Function src_compile, Line 55, Exitcode 2 !!! (no error message) ---------------------------------------------------------- I have libpcap installed: ---------------------------------------------------------- * net-libs/libpcap Latest version available: 0.7.2-r1 Latest version installed: 0.7.2 ---------------------------------------------------------- But pcap-bpf.h doesn't appear to be among the files that come with libpcap 0.7.2: ---------------------------------------------------------- philonous tmp # qpkg -l libpcap net-libs/libpcap-0.7.2-r1 * CONTENTS: /usr /usr/include /usr/include/pcap.h /usr/include/net /usr/include/net/bpf.h /usr/include/pcap-namedb.h /usr/lib /usr/lib/libpcap.so.0.7 /usr/lib/libpcap.a /usr/lib/libpcap.so.0 -> /usr/lib/libpcap.so.0.7 /usr/lib/libpcap.so -> /usr/lib/libpcap.so.0.7 /usr/share /usr/share/man /usr/share/man/man3 /usr/share/man/man3/pcap.3.gz /usr/share/doc /usr/share/doc/libpcap-0.7.2-r1 /usr/share/doc/libpcap-0.7.2-r1/FILES.gz /usr/share/doc/libpcap-0.7.2-r1/README.aix.gz /usr/share/doc/libpcap-0.7.2-r1/README.tru64.gz /usr/share/doc/libpcap-0.7.2-r1/LICENSE.gz /usr/share/doc/libpcap-0.7.2-r1/CREDITS.gz /usr/share/doc/libpcap-0.7.2-r1/README.hpux.gz /usr/share/doc/libpcap-0.7.2-r1/README.linux.gz /usr/share/doc/libpcap-0.7.2-r1/CHANGES.gz /usr/share/doc/libpcap-0.7.2-r1/VERSION.gz /usr/share/doc/libpcap-0.7.2-r1/README.gz philonous tmp # find /usr/include/ | grep pcap /usr/include/pcap.h /usr/include/pcap-namedb.h ---------------------------------------------------------- I don't normally run ~x86, but I want ppp-2.4.2. I'm backing up my system and then I'll upgrade libpcap with ACCEPT_KEYWORDS="~x86" (and I'll get ~x86 glibc, gcc, etc...), and perhaps pcap-bpf.h will show up then. I realize this package is marked ~x86, but figured it wouldn't hurt to mention that I was seeing this problem. Update libpcap to ~x86, and it will compile. x86 libpcap currently has "pcap.h" and ~x86 libpcap has "pcap-bpf.h". |