Summary: | Keword ~x86-fbsd on dev-java/libmatthew-java | ||
---|---|---|---|
Product: | Gentoo/Alt | Reporter: | Naohiro Aota <naota> |
Component: | FreeBSD | Assignee: | Gentoo/BSD Team <bsd+disabled> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | java |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | FreeBSD | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 232411 | ||
Attachments: | libmatthew-java-0.7.2-makefile-fixes.patch.patch |
Any comment on this patch? I'll apply it if you don't see any problem. Looks fine, go ahead. Thanks. Patch and ~x86-fbsd added, thanks. Leave this for ~amd64-fbsd KEYWORDing. (In reply to comment #3) > Leave this for ~amd64-fbsd KEYWORDing. if someone has interest and tests it on amd64-fbsd, yes, but for now, no closing See Alexis' answer. |
Created attachment 303491 [details, diff] libmatthew-java-0.7.2-makefile-fixes.patch.patch We need libmatthew-java keyworded to keyword zemberek-server (#232411). The current files/libmatthew-java-0.7.2-makefile-fixes.patch have two problems. 1. It specify "-I$(JAVA_HOME)/include/linux" which does not exists on FreeBSD (or any non-Linux platforms) 2. It leave "make"s untouched, which should be replaced with "$(MAKE)" to work also when it is called "gmake" The attached patch for files/libmatthew-java-0.7.2-makefile-fixes.patch is for 1. Don't set INCLUDES anymore. INCLUDES are properly set with INCLUDES="$(java-pkg_get-jni-cflags)" in the ebuild 2. Replace "make"s wiht "$(MAKE)" Java team, if you don't see any problem with the patch, could you apply it or give me ACK to commit the change.