Summary: | app-laptop/laptop-mode-tools fails to start with kernel 3.1 | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Erich Seifert <eseifert> |
Component: | New packages | Assignee: | Mobile Herd (OBSOLETE) <mobile+disabled> |
Status: | RESOLVED WONTFIX | ||
Severity: | normal | CC: | aidanamarks, fedotov.i.f, hwoarang, octavsly, orlovm, tiago, ulm, wicher |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | AMD64 | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
Drop kernel version check from laptop-mode-tools 1.55
Drop kernel version check from laptop-mode-tools 1.55 module patch to make laptop-mode-tools-1.55 work with all 3.x kernels |
Description
Erich Seifert
2011-10-26 12:54:50 UTC
Created attachment 290873 [details, diff]
Drop kernel version check from laptop-mode-tools 1.55
I backported upstream commit aa798a6ebbba which removes the check for kernel version as it was never used actually. This allows the daemon to start again.
(In reply to comment #1) > Created attachment 290873 [details, diff] > Drop kernel version check from laptop-mode-tools 1.55 I believe that this patch is incomplete. There are additional tests for the kernel version in usr/share/laptop-mode-tools/modules/laptop-mode. Created attachment 290953 [details, diff]
Drop kernel version check from laptop-mode-tools 1.55 module
Added backport of upstream commit cf00a0a651d25f406ba6a825268916f737e38f20 which removes kernel version checks also from /usr/share/laptop-mode-tools/modules/laptop-mode. Best would be to do a version bump to laptop-mode-tools 1.58 or higher though.
With the two patches it works here. This is fixed upstream; bug #390709 bumps laptop-mode-tools to v1.60 . Created attachment 293609 [details, diff]
patch to make laptop-mode-tools-1.55 work with all 3.x kernels
IMHO, it is better not to prevent kernel version checking, so I propose this patch which should work with all 3.x kernels for laptop-mode-tools-1.55 until newer versions are in portage. At least it works on my laptop.
Thanks for the patch but this is fixed by upstream in version 1.60. So closing this bug as WONTFIX |